Cleanup tests

Fix ResourceWarnings due to unclosed files.
Remove fake-nm.py and corresponding input files (not used anymore).

Reviewed By: cmatthews

Differential Revision: https://reviews.llvm.org/D144025

Author: kpdev

tests/testing/Inputs/fake-nm.py

@@ -1,16 +1,19 @@
 import sys
 
-for a in sys.argv:
-    if a.startswith('--start-address'):
-        addr = a.split('=')[1]
 
-        fname = '%s.%s.out' % (sys.argv[1], addr)
-        sys.stdout.write(open(fname).read())
-        sys.exit(0)
+def exit_with_fake_output(suffix):
+    fname = '%s.%s' % (sys.argv[1], suffix)
+    with open(fname) as f:
+        sys.stdout.write(f.read())
+    sys.exit(0)
 
-    if a.startswith('-t'):
-        fname = '%s.out' % sys.argv[1]
-        sys.stdout.write(open(fname).read())
-        sys.exit(0)
+
+for arg in sys.argv:
+    if arg.startswith('--start-address'):
+        addr = arg.split('=')[1]
+        exit_with_fake_output('%s.out' % addr)
+
+    if arg.startswith('-t'):
+        exit_with_fake_output('out')
 
 sys.exit(1)

tests/testing/Inputs/fake-objdump.py

@@ -170,30 +170,28 @@ def _getObjdump(self, perf_data_fname):
     def _getInput(self, fname):
         return os.path.join(self.inputs, fname)
 
+    def _loadPerfDataInput(self, fname):
+        perf_data = self._getInput(fname)
+        fake_objdump = self._getObjdump(perf_data)
+        with open(perf_data, 'rb') as f:
+            return LinuxPerfProfile.deserialize(
+                f, objdump=fake_objdump, propagateExceptions=True)
+
     def test_check_file(self):
         self.assertTrue(LinuxPerfProfile.checkFile(self._getInput('fib-aarch64.perf_data')))
 
     def test_aarch64_fib(self):
-        perf_data = self._getInput('fib-aarch64.perf_data')
-        p = LinuxPerfProfile.deserialize(open(perf_data, 'rb'),
-                                         objdump=self._getObjdump(perf_data),
-                                         propagateExceptions=True)
+        p = self._loadPerfDataInput('fib-aarch64.perf_data')
 
         self.assertEqual(p.data, self.expected_data['fib-aarch64'])
 
     def test_aarch64_fib2(self):
-        perf_data = self._getInput('fib2-aarch64.perf_data')
-        p = LinuxPerfProfile.deserialize(open(perf_data, 'rb'),
-                                         objdump=self._getObjdump(perf_data),
-                                         propagateExceptions=True)
+        p = self._loadPerfDataInput('fib2-aarch64.perf_data')
 
         self.assertEqual(p.data, self.expected_data['fib2-aarch64'])
 
     def test_aarch64_fib2_nondynamic(self):
-        perf_data = self._getInput('fib2-aarch64.perf_data')
-        p = LinuxPerfProfile.deserialize(open(perf_data, 'rb'),
-                                         objdump=self._getObjdump(perf_data),
-                                         propagateExceptions=True)
+        p = self._loadPerfDataInput('fib2-aarch64.perf_data')
 
         self.assertEqual(p.data, self.expected_data['fib2-aarch64'])
 

tests/testing/Inputs/fib-aarch64.nm.out

@@ -54,7 +54,8 @@ def test_saveFromRendered(self):
 
         with tempfile.NamedTemporaryFile() as f:
             Profile.saveFromRendered(s, filename=f.name)
-            p2 = ProfileV1.deserialize(open(f.name, "rb"))
+            with open(f.name, 'rb') as f2:
+                p2 = ProfileV1.deserialize(f2)
 
         self.assertEqual(p2.data, self.test_data)