Merge pull request #171 from matthewseaman/give-me-a-valid-pointer

Pass valid count pointer to `LLVMGetModuleIdentifier`

Author: CodaFi

Sources/LLVM/Module.swift

@@ -110,7 +110,8 @@ public final class Module: CustomStringConvertible {
   /// The identifier of this module.
   public var name: String {
     get {
-      guard let id = LLVMGetModuleIdentifier(llvm, nil) else { return "" }
+      var count = 0
+      guard let id = LLVMGetModuleIdentifier(llvm, &count) else { return "" }
       return String(cString: id)
     }
     set {

Tests/LLVMTests/ModuleLinkSpec.swift

@@ -9,6 +9,7 @@ class ModuleLinkSpec : XCTestCase {
       // MODULE-LINK: ; ModuleID = '[[ModuleName1:ModuleLinkModuleOne]]'
       // MODULE-LINK-NEXT: source_filename = "[[ModuleName1]]"
       let module1 = Module(name: "ModuleLinkModuleOne")
+      XCTAssertEqual(module1.name, "ModuleLinkModuleOne")
       let builder1 = IRBuilder(module: module1)
       // MODULE-LINK: define void @moduleOne() {
       let mod1f = builder1.addFunction("moduleOne",
@@ -25,6 +26,7 @@ class ModuleLinkSpec : XCTestCase {
       // MODULE-LINK: ; ModuleID = '[[ModuleName2:ModuleLinkModuleTwo]]'
       // MODULE-LINK-NEXT: source_filename = "[[ModuleName2]]"
       let module2 = Module(name: "ModuleLinkModuleTwo")
+      XCTAssertEqual(module2.name, "ModuleLinkModuleTwo")
       let builder2 = IRBuilder(module: module2)
       // MODULE-LINK: define void @moduleTwo() {
       let mod2f = builder2.addFunction("moduleTwo",