feat: Add initial metrics and update dependencies #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirrozenbaum
reviewed
Nov 3, 2025
shmuelk
previously requested changes
Nov 4, 2025
nirrozenbaum
reviewed
Nov 4, 2025
nirrozenbaum
reviewed
Nov 4, 2025
nirrozenbaum
reviewed
Nov 4, 2025
nirrozenbaum
reviewed
Nov 4, 2025
nirrozenbaum
reviewed
Nov 4, 2025
nirrozenbaum
reviewed
Nov 4, 2025
nirrozenbaum
reviewed
Nov 4, 2025
nirrozenbaum
reviewed
Nov 4, 2025
JeffLuoo
force-pushed
the
main
branch
3 times, most recently
from
2c3e179 to
086cc34
Compare
Collaborator
|
@JeffLuoo any update regarding this PR? |
Contributor
Author
|
@nirrozenbaum Yes. I will follow up with @kfswain on a branch cut in EPP so I can bump the version in this PR. |
JeffLuoo
force-pushed
the
main
branch
2 times, most recently
from
256f457 to
cf0d629
Compare
Contributor
Author
|
@nirrozenbaum This PR is now ready for review |
Collaborator
|
This PR is targeted for v0.4. |
Collaborator
nirrozenbaum
left a comment
nirrozenbaum
left a comment
There was a problem hiding this comment.
Thanks @JeffLuoo.
overall it lgtm, I left few minor comments.
Collaborator
|
/lgtm |
github-actions
bot
added
the
lgtm
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nirrozenbaum
previously approved these changes
Nov 22, 2025
Collaborator
|
@JeffLuoo linter issues.. |
This commit introduces Prometheus metrics to the scheduler, starting with a request counter. Signed-off-by: jeffluoo <jeffluoo@google.com>
JeffLuoo
dismissed stale reviews from nirrozenbaum and github-actions[bot]
via
e317a92
Contributor
Author
|
/retest |
Collaborator
|
/lgtm |
Collaborator
|
@JeffLuoo lgtm, please sign the commits |
github-project-automation
bot
moved this from In review
to Done
in llm-d-inference-scheduler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces Prometheus metrics to the scheduler, starting with a request counter.
It also updates several Go dependencies and adjusts the Dockerfile to work with the vendored dependencies.