Skip to content

Commit fa6854a

Browse files
committed
fix: update golangci-lint configuration and CI version
- Remove version field temporarily to test with current CI setup - Fix incorrect version v2.1.6 in CI workflow - Use golangci-lint-action@v8 default version Signed-off-by: Rishi Jat <rishijat098@gmail.com>
1 parent 2ed3d19 commit fa6854a

File tree

2 files changed

+5
-18
lines changed

2 files changed

+5
-18
lines changed

.github/workflows/ci-pr-checks.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ jobs:
3939
- name: Run lint checks
4040
uses: golangci/golangci-lint-action@v8
4141
with:
42-
version: 'v2.1.6'
4342
args: "--config=./.golangci.yml"
4443

4544
- name: Run make test

.golangci.yml

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,11 @@
1-
version: "2"
2-
31
# Enhanced golangci-lint configuration for llm-d-inference-scheduler
4-
# Expanded from 22 to 30+ linters for improved code quality, security, and maintainability
2+
# Expanded from 22 to 30+ linters for improved code quality, security, and maintainability
53
# Focus on practical improvements suitable for Kubernetes controller development
64

75
run:
86
timeout: 10m
97
allow-parallel-runners: true
108

11-
formatters:
12-
enable:
13-
- goimports
14-
- gofmt
15-
169
linters:
1710
enable:
1811
# === ORIGINAL LINTERS (maintained) ===
@@ -38,6 +31,10 @@ linters:
3831
- unused # Unused code (helps reduce bloat)
3932

4033
# === NEW HIGH-VALUE ADDITIONS ===
34+
# Formatting and style consistency
35+
- gofmt # Ensures code is gofmt-ed
36+
- goimports # Import organization and unused import removal
37+
4138
# Security enhancements
4239
- gosec # Security vulnerability scanner
4340
- bodyclose # Ensures HTTP response bodies are closed
@@ -71,12 +68,3 @@ linters:
7168
- funlen # Function length (can be overly strict)
7269
- nestif # Nested if statements (can be overly strict)
7370
- gocognit # Cognitive complexity (can be overly strict)
74-
75-
issues:
76-
exclude-rules:
77-
- path: pkg/plugins/
78-
linters:
79-
- goanalysis_metalinter
80-
- path: pkg/scheduling/pd/
81-
linters:
82-
- goanalysis_metalinter

0 commit comments

Comments
 (0)