Skip to content

Commit 005c113

Browse files
committed
remove klog
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
1 parent 41ee203 commit 005c113

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

cmd/pd-sidecar/main.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,9 @@ import (
2323
"strconv"
2424
"strings"
2525

26-
"k8s.io/klog/v2"
2726
ctrl "sigs.k8s.io/controller-runtime"
27+
"sigs.k8s.io/controller-runtime/pkg/log"
28+
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2829

2930
"github.com/llm-d/llm-d-inference-scheduler/pkg/sidecar/proxy"
3031
"github.com/llm-d/llm-d-inference-scheduler/pkg/sidecar/version"
@@ -58,14 +59,15 @@ func main() {
5859
inferencePoolName := flag.String("inference-pool-name", os.Getenv("INFERENCE_POOL_NAME"), "the specific InferencePool name to watch (defaults to INFERENCE_POOL_NAME env var)")
5960
enablePrefillerSampling := flag.Bool("enable-prefiller-sampling", func() bool { b, _ := strconv.ParseBool(os.Getenv("ENABLE_PREFILLER_SAMPLING")); return b }(), "if true, the target prefill instance will be selected randomly from among the provided prefill host values")
6061

61-
klog.InitFlags(nil)
62+
opts := zap.Options{}
63+
opts.BindFlags(flag.CommandLine) // optional to allow zap logging control via CLI
6264
flag.Parse()
6365

64-
// make sure to flush logs before exiting
65-
defer klog.Flush()
66+
logger := zap.New(zap.UseFlagOptions(&opts))
67+
log.SetLogger(logger)
6668

6769
ctx := ctrl.SetupSignalHandler()
68-
logger := klog.FromContext(ctx)
70+
log.IntoContext(ctx, logger)
6971

7072
logger.Info("Proxy starting", "Built on", version.BuildRef, "From Git SHA", version.CommitSHA)
7173

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ require (
2121
k8s.io/apiextensions-apiserver v0.34.2
2222
k8s.io/apimachinery v0.34.2
2323
k8s.io/client-go v0.34.2
24-
k8s.io/klog/v2 v2.130.1
2524
k8s.io/utils v0.0.0-20250820121507-0af2bda4dd1d
2625
sigs.k8s.io/controller-runtime v0.22.4
2726
sigs.k8s.io/gateway-api v1.4.0
@@ -125,6 +124,7 @@ require (
125124
gopkg.in/yaml.v3 v3.0.1 // indirect
126125
k8s.io/apiserver v0.34.2 // indirect
127126
k8s.io/component-base v0.34.2 // indirect
127+
k8s.io/klog/v2 v2.130.1 // indirect
128128
k8s.io/kube-openapi v0.0.0-20250814151709-d7b6acb124c3 // indirect
129129
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2 // indirect
130130
sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 // indirect

0 commit comments

Comments
 (0)