fixed: the default packaged luacheck executable is not macos/linux format, try to find a valid luacheck executable using which luacheck shell command.

- #107 Ship UNIX luacheck binaries in addition to Windows ones
- #106 Crashes after VSCode update
- #104 LuaCoderAssist Crash
- #102 Crash when luacheck is not available
- #86  安裝後立即出錯，無法使用。

Author: liwangqian

server/providers/diagnostic-provider.js

@@ -98,15 +98,21 @@ class DiagnosticProvider {
     _run(linter, input) {
         return new Promise((resolve, reject) => {
             /*重新创建一个检查进程*/
-            let proc = execFile(linter.cmd, linter.args, { cwd: linter.cwd }, (error, stdout, stderr) => {
-                if (error != null) {
-                    reject({ error: error, stdout: stdout, stderr: stderr });
-                } else {
-                    resolve({ error: error, stdout: stdout, stderr: stderr });
-                }
-            });
+            try {
+                let proc = execFile(linter.cmd, linter.args, { cwd: linter.cwd }, (error, stdout, stderr) => {
+                    if (error != null) {
+                        reject({ error: error, stdout: stdout, stderr: stderr });
+                    } else {
+                        resolve({ error: error, stdout: stdout, stderr: stderr });
+                    }
+                });
 
-            proc.stdin.end(input);
+                proc.stdin.end(input);
+            } catch (e) {
+                console.error(`execute '${linter.cmd} ${linter.args.join(' ')}' failed.`);
+                console.error(e);
+                reject({error: e});
+            }
         });
     }
 

server/providers/lib/linters.js

@@ -1,10 +1,12 @@
 'use strict';
 
 const engine = require('../../lib/engine');
+const utils_1 = require('./utils');
 const uri_1 = require('vscode-uri').default;
 const langserver_1 = require('vscode-languageserver');
 const path_1 = require('path');
 const fs_1 = require('fs');
+const os = require('os')
 
 // default to 64-bit windows luacheck.exe, from https://github.com/mpeterv/luacheck/releases
 const default_luacheck_executor = path_1.resolve(__dirname, '../../../3rd/luacheck/luacheck.exe');
@@ -23,9 +25,20 @@ function isFileSync(aPath) {
     }
 }
 
+function getLuacheckExecutor() {
+    let osType = os.type().toLowerCase();
+    if (osType.includes('windows')) {
+        return default_luacheck_executor;
+    } else {
+        return utils_1.getExePath('luacheck');
+    }
+}
+
 class Luacheck {
     constructor(coder) {
         this.coder = coder;
+        this.exePath = getLuacheckExecutor();
+        console.info(`[INFO] using '${this.exePath}'`)
     }
 
     command(document) {
@@ -47,7 +60,7 @@ class Luacheck {
         const fileName = uri_1.parse(document.uri).fsPath;
         args.push("--filename", fileName, "-"); //use stdin
 
-        let cmd = settings.execPath || default_luacheck_executor;
+        let cmd = settings.execPath || this.exePath;
         let cwd = path_1.dirname(luacheckrc_path || fileName);
 
         return {

server/providers/lib/utils.js

@@ -530,3 +530,10 @@ function findAllReferences(references, def) {
 }
 
 exports.findAllReferences = findAllReferences;
+
+const execSync = require('child_process').execSync
+function getExePath(extName) {
+    return execSync(`which ${extName}`).toString().replace(/[\r\n]/g, '');
+}
+
+exports.getExePath = getExePath;