Skip to content

Commit 9e7176c

Browse files
committed
优化:#90 Cannot read property 'description' of null
优化:#86 避免访问undefined域
1 parent 344d49d commit 9e7176c

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

client/commands/codemetrics-details.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class ShowMetricsDetails {
7070
placeHolder: 'Click to review more details introduction',
7171
}
7272
).then(item => {
73-
item.onDidPressKey();
73+
item && item.onDidPressKey();
7474
});
7575
}
7676
};

server/providers/completion-provider.js

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,15 @@ class CompletionProvider {
6464
const override = item.data.override;
6565
const selfAsParam = item.data.selfAsParam;
6666
item.detail = utils.symbolSignature(data, override);
67-
const description = data.type.description || '';
68-
const link = data.type.link;
69-
const desc = (override !== undefined) ? data.type.variants[override].description : description;
70-
item.documentation = {
71-
kind: langserver.MarkupKind.Markdown,
72-
value: desc + (link ? ` \r\n[more...](${link})` : '')
73-
};
67+
if (data.type) {
68+
const description = data.type.description || '';
69+
const link = data.type.link;
70+
const desc = (override !== undefined) ? data.type.variants[override].description : description;
71+
item.documentation = {
72+
kind: langserver.MarkupKind.Markdown,
73+
value: desc + (link ? ` \r\n[more...](${link})` : '')
74+
};
75+
}
7476
const insertParams = this.coder.settings.completion.autoInsertParameters;
7577
utils.functionSnippet(item, data, override, selfAsParam, insertParams);
7678
return item;

0 commit comments

Comments
 (0)