Skip to content

Commit 7bcf4d8

Browse files
authored
Default to exact device matching (#1119)
1 parent 15b8bc6 commit 7bcf4d8

File tree

7 files changed

+25
-28
lines changed

7 files changed

+25
-28
lines changed

.changeset/silver-eyes-double.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@livekit/components-react": patch
3+
---
4+
5+
Default to exact device matching

packages/core/src/track-reference/test-utils.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ export const mockTrackReferencePublished = (id: string, source: Track.Source): T
2929
});
3030
return {
3131
participant: new Participant(`${id}`, `${id}`),
32-
// @ts-expect-error
3332
publication: new RemoteTrackPublication(kind, trackInfo, true),
3433
source: source,
3534
};
@@ -54,7 +53,6 @@ export const mockTrackReferenceSubscribed = (
5453
name: `${id}`,
5554
muted: false,
5655
});
57-
// @ts-expect-error
5856
const publication = new RemoteTrackPublication(kind, trackInfo, true);
5957
// @ts-expect-error
6058
publication.track = {};

packages/react/src/components/controls/MediaDeviceSelect.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export const MediaDeviceSelect: (
9898

9999
const handleActiveDeviceChange = async (deviceId: string) => {
100100
try {
101-
await setActiveMediaDevice(deviceId, { exact: exactMatch });
101+
await setActiveMediaDevice(deviceId, { exact: exactMatch ?? true });
102102
} catch (e) {
103103
if (e instanceof Error) {
104104
onDeviceSelectError?.(e);

packages/react/src/prefabs/PreJoin.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export function usePreviewDevice<T extends LocalVideoTrack | LocalAudioTrack>(
128128
const track =
129129
kind === 'videoinput'
130130
? await createLocalVideoTrack({
131-
deviceId: deviceId,
131+
deviceId,
132132
resolution: VideoPresets.h720.resolution,
133133
})
134134
: await createLocalAudioTrack({ deviceId });

pnpm-lock.yaml

Lines changed: 16 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pnpm-workspace.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ packages:
55
- 'tooling/*'
66

77
catalog:
8-
livekit-client: ^2.9.5
8+
livekit-client: ^2.11.0

tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
// see https://www.typescriptlang.org/tsconfig to better understand tsconfigs
3+
"exclude": ["node_modules", "dist", "**/*.test.ts"],
34
"compilerOptions": {
45
"module": "esnext",
56
"lib": ["dom", "esnext"],

0 commit comments

Comments
 (0)