Typesafe errors in connection path #1763
Conversation
🦋 Changeset detectedLatest commit: 6af2ac1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| if (reconnectResult.isErr()) { | ||
| return err(reconnectResult.error); | ||
| return err( | ||
| new SignalReconnectError( |
There was a problem hiding this comment.
one of the errors was caused by this method returning a ConnectionError for some reason the return type on the resumeConnection method isn't being type checked here it seems.
This led to the reconnect flow triggering a "full reconnect" instead of a "resume" as "resumes" can only happen for SignalReconnectErrors
| self.emit(EngineEvent.SignalRestarted, joinResult.value); | ||
|
|
||
| await self.waitForPCReconnected(); | ||
| yield* await self.waitForPCReconnected(); |
There was a problem hiding this comment.
the other error was caused by self.waitForPCReconnected throwing.
This is the pitfall of doing a gradual adoption of this pattern. Extra care needed for ensuring that if a method is expected to not throw anymore it actually won't
|
will try to break this up in smaller PRs, starting with #1764 |
No description provided.