Add new areTokenSourceFetchOptionsEqual function
#1733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is needed for use in `components-js` so I can fix an issue reported by Thom [here](livekit-examples/agent-starter-react#298 (comment)) related to the useSession return not being a stable reference due to fetch options changing every render.
🦋 Changeset detectedLatest commit: 312b8a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1egoman
changed the title
areTokenSourceFetchOptionsEqual function
Contributor
size-limit report 📦
|
lukasIO
approved these changes
Nov 10, 2025
Merged
This was referenced Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was adapted from a previous change that didn't end up being merged here: https://github.com/livekit/client-sdk-js/pull/1677/files#diff-22b723d0af595b5715d5a1f039d62bf3a1829350c8591d0486565a9a92ba33f4R38-R63
It is now needed for use in
components-jsso I can fix an issue reported by @thomasyuill-livekit here related to the useSession return not being a stable reference due to fetch options changing every render.