Skip to content

Account for spatial layers in default video encoding for SVC codecs #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+12 −1
Draft

Account for spatial layers in default video encoding for SVC codecs #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04a32e7
Account for spatial layers in default video encoding for SVC codecs
lukasIO May 14, 2024
cf33860
use new var in logic
lukasIO May 15, 2024
577f212
Revert "use new var in logic"
lukasIO May 15, 2024
867adb6
Create orange-cobras-lie.md
lukasIO May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/orange-cobras-lie.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"livekit-client": patch
---

Account for spatial layers in default video encoding for SVC codecs
8 changes: 7 additions & 1 deletion src/room/participant/publishUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ export function computeVideoEncodings(
return [{}];
}

let useDefaultVideoEncoding = !videoEncoding;

if (!videoEncoding) {
// find the right encoding based on width/height
videoEncoding = determineAppropriateEncoding(isScreenShare, width, height, videoCodec);
Expand Down Expand Up @@ -163,8 +165,12 @@ export function computeVideoEncodings(
/* @ts-ignore */
encodings[0].scalabilityMode = scalabilityMode;
} else {
const svcBitrate = useDefaultVideoEncoding
? // account for spatial layers if default video encoding computation has been used to determine bitrate
original.encoding.maxBitrate * Math.cbrt(sm.spatial)
: original.encoding.maxBitrate;
encodings.push({
maxBitrate: videoEncoding.maxBitrate,
maxBitrate: svcBitrate,
maxFramerate: original.encoding.maxFramerate,
/* @ts-ignore */
scalabilityMode: scalabilityMode,
Expand Down