TODOs

Author: pblazej

VoiceAgent/Agent/AgentSession.swift

@@ -116,7 +116,7 @@ final class AgentSession: ObservableObject {
         }
 
         let connection = { @Sendable in
-            let (server, token) = try! await self.credentials()
+            let (server, token) = try await self.credentials()
             try await self.room.connect(url: server, token: token, connectOptions: options, roomOptions: roomOptions)
         }
 

VoiceAgent/App/AppView.swift

@@ -51,6 +51,9 @@ struct AppView: View {
     @ViewBuilder
     private func start() -> some View {
         StartView()
+            .onAppear {
+                chat = false
+            }
     }
 
     @ViewBuilder

VoiceAgent/Auth/Sandbox.swift

@@ -12,10 +12,13 @@ enum Sandbox {
     struct Connection: Decodable {
         let serverUrl: String
         let participantToken: String
+        let roomName: String
+        let participantName: String
     }
 
     private static let url: String = "https://cloud-api.livekit.io/api/sandbox/connection-details"
 
+    // TODO: These are not respected anyway (names)
     static func getConnection(id: String, roomName: String, participantName: String) async throws -> Connection {
         var urlComponents = URLComponents(string: url)!
         urlComponents.queryItems = [

VoiceAgent/Chat/View/ChatScrollView.swift

@@ -21,9 +21,22 @@ struct ChatScrollView<Content: View>: View {
                 scrollView.scrollTo(session.messages.keys.last)
             }
             .upsideDown()
-            .padding(.horizontal)
             .scrollIndicators(.never)
             .animation(.default, value: session.messages)
         }
     }
 }
+
+private struct UpsideDown: ViewModifier {
+    func body(content: Content) -> some View {
+        content
+            .rotationEffect(.radians(Double.pi))
+            .scaleEffect(x: -1, y: 1, anchor: .center)
+    }
+}
+
+private extension View {
+    func upsideDown() -> some View {
+        modifier(UpsideDown())
+    }
+}

VoiceAgent/Chat/View/ChatView.swift

@@ -5,6 +5,7 @@ struct ChatView: View {
 
     var body: some View {
         ChatScrollView(messageBuilder: message)
+            .padding(.horizontal)
     }
 
     @ViewBuilder

VoiceAgent/Helpers/View+.swift

@@ -1,16 +1,5 @@
 import SwiftUI
 
-/// A view modifier that flips the view upside down.
-/// It may be used to create e.g. an inverted List.
-/// - SeeAlso: ``ChatView``
-struct UpsideDown: ViewModifier {
-    func body(content: Content) -> some View {
-        content
-            .rotationEffect(.radians(Double.pi))
-            .scaleEffect(x: -1, y: 1, anchor: .center)
-    }
-}
-
 /// A view modifier that slightly blurs the top of the view.
 struct BlurredTop: ViewModifier {
     func body(content: Content) -> some View {
@@ -50,11 +39,6 @@ struct Shimerring: ViewModifier {
 }
 
 extension View {
-    /// Flips the view upside down.
-    func upsideDown() -> some View {
-        modifier(UpsideDown())
-    }
-
     /// Blurs the top of the view.
     func blurredTop() -> some View {
         modifier(BlurredTop())