Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Commit 50df204

Browse files
livecodefraserlivecodeian
authored andcommitted
Use ARM instruction encoding if building Skia for ARMv6
Skia uses inline assembly that is incompatible with the Thumb instructions available in ARMv6 and so cannot be built in Thumb mode. ARMv7 and higher does provide those instructions in Thumb mode and therefore does not need to be built in ARM mode.
1 parent 41cd45f commit 50df204

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

libskia/libskia.gyp

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,23 @@
133133
],
134134
},
135135

136+
'target_defaults':
137+
{
138+
'target_conditions':
139+
[
140+
[
141+
'toolset_os == "android" and toolset_arch == "armv6"',
142+
{
143+
'cflags':
144+
[
145+
# Skia won't compile to ARMv6 Thumb
146+
'-marm',
147+
],
148+
},
149+
],
150+
],
151+
},
152+
136153
'targets':
137154
[
138155
# We define separate targets for each set of optimizations as they need

0 commit comments

Comments
 (0)