Merge remote-tracking branch 'origin/release-9.0.0' into merge-release-9.0.0-28.03.2018

Author: livecodepanos

Toolset/libraries/revdebuggerlibrary.livecodescript

@@ -2071,6 +2071,9 @@ command revDebuggerUpdateScriptEditor pObject, pHandler, pLine, pState, pError
    revGoScriptEditor the name of stack tScriptEditor
 
    if pError is not empty then
+      if the number of items of pError is 1 then
+         put comma & pLine after pError
+      end if
       # OK-2008-07-10 : This needs to be sent in time so that it arrives after the script
       # editor has finished initializing itself.
       send "revSEDisplayExecutionError pError, pObject" to stack tScriptEditor in 0 milliseconds

Toolset/libraries/revideextensionlibrary.livecodescript

@@ -1066,7 +1066,8 @@ private command __revIDELCBExtensionLoad pID, pFolder, pVersion, pStatus, \
    put pAdditionalInfoA["support_files"] into tSupportFiles
    local tLoadOnStartup
    if pError is empty then
-      put revIDEExtensionGetLoadOnStartup(pID) into tLoadOnStartup
+      put pAdditionalInfoA["_ide"] is true or \
+            revIDEExtensionGetLoadOnStartup(pID) into tLoadOnStartup
    end if
    if not pIsStartup or tLoadOnStartup is not false then
       __LoadExtension tCacheIndex, "lcb", pSourceFile, pFolder, pStatus, pError

Toolset/libraries/revidelibrary.8.livecodescript

@@ -11876,7 +11876,14 @@ function revIDELookupError pType, pError
       else if tCode is kExternalHandlerErrorCode then
          return "External handler execution error:" && item 4 to -1 of line 1 of pError
       end if
-      return line tCode of the scriptExecutionErrors
+      
+      if tCode is an integer then
+         get line tCode of the scriptExecutionErrors
+         if it is not empty then
+            return it
+         end if
+      end if
+      return tCode
    else if pType is "warning" then
       return empty
    end if

Toolset/palettes/dictionary/behaviors/revdictionarybehavior.livecodescript

@@ -1,4 +1,4 @@
-script "revDictionaryBehavior"
+script "revDictionaryBehavior" with behavior "revPaletteBehavior"
 -- The dictionary starts to hide elements at lower than 992 pixels
 -- *TODO* Tweak the CSS to rearrange things appropriately 
 constant kDictionaryMinWidth = 992
@@ -93,5 +93,11 @@ end showUpgradeOptions
 
 # bug 17819 enable cmd+c in dictionary
 on commandKeyDown pWhich
-   if pWhich is not "C" then pass commandKeyDown
+   if pWhich is not "C" then 
+      if pWhich is "W" then
+         close me
+      else 
+         pass commandKeyDown
+      end if
+   end if
 end commandKeyDown

Toolset/palettes/extension manager/revideextensionmanagerrowbehavior.livecodescript

@@ -124,12 +124,14 @@ private function __MenuActionsForRow pDataA
       put tShow after tActions
    end if
 
-   local tLoadOnStartup
-   put "Load on startup/|Toggle Load" & return into tLoadOnStartup
-   if revIDEExtensionGetLoadOnStartup(pDataA["name"]) is not false then
-      put "!c" before tLoadOnStartup
+   if not pDataA["_ide"] then
+      local tLoadOnStartup
+      put "Load on startup/|Toggle Load" & return into tLoadOnStartup
+      if revIDEExtensionGetLoadOnStartup(pDataA["name"]) is not false then
+         put "!c" before tLoadOnStartup
+      end if
+      put tLoadOnStartup after tActions
    end if
-   put tLoadOnStartup after tActions
 
    local tSampleList
    if pDataA["samples"] is not empty then

Toolset/palettes/revdatagridlibrary/behaviorsdatagridbuttonbehavior.livecodescript

@@ -3560,52 +3560,78 @@ end _table.ScrollColumnIntoView
 
 
 private command _table.LayoutDataArea
-   local theViewRect, theRect, theRootGroup
+   local theViewRect, theRect
    put _WorkingGroupRect(the long ID of me) into theViewRect
    put theViewRect into theRect
-   put the long ID of group "dgHeaderComponents" of me into theRootGroup
 
-   ## Shift all content
-   set the topLeft of theRootGroup to item 1 to 2 of theRect
-   
-   ## Reposition bottom element
-   local theSBWidth
-   if the visible of scrollbar "dgScrollbar" of me then put the width of scrollbar "dgScrollbar" of me into theSBWidth
-   else put the dgProps["scrollbar corner offset"] of me into theSBWidth
-   set the visible of graphic "dgCornerPiece" of group "dgHorizontalComponents" of me to the visible of scrollbar "dgScrollbar" of me
-   
-   set the rect of scrollbar "dgHScrollbar" of group "dgHorizontalComponents" of me to \
-         item 1 of theRect, item 4 of theRect - the height of scrollbar "dgHScrollbar" of group "dgHorizontalComponents" of me, \
-         item 3 of theRect - theSBWidth, item 4 of theRect
+   local tHeaderComponents, tHorizontalComponents
+   local tVScrollbar, tHScrollbar, tCornerPiece
+   put the long id of group "dgHeaderComponents" of me into tHeaderComponents
+   put the long id of group "dgHorizontalComponents" of me into tHorizontalComponents
+   put the long id of scrollbar "dgScrollbar" of me into tVScrollbar
+   put the long id of scrollbar "dgHScrollbar" of tHorizontalComponents into tHScrollbar
+   put the long id of graphic "dgCornerPiece" of tHorizontalComponents into tCornerPiece
 
-   ## Header mask
-   put the bottom of group "dgHeaderMask" of theRootGroup into item 4 of theRect            
-   set the rect of group "dgHeaderMask" of theRootGroup to theRect
+   ## Shift all content
+   set the topLeft of tHeaderComponents to item 1 to 2 of theRect
 
-   ## Define new top/bottom
-   if the visible of theRootGroup then
-      put item 4 of theRect into item 2 of theRect                 
+   if the visible of tHeaderComponents then
+      # Set the rect of the header mask
+      local tHeaderMaskRect
+      put theRect into tHeaderMaskRect
+      put the bottom of group "dgHeaderMask" of tHeaderComponents into item 4 of tHeaderMaskRect            
+      set the rect of group "dgHeaderMask" of tHeaderComponents to tHeaderMaskRect
+      ## Define new top of content rect
+      put item 4 of tHeaderMaskRect into item 2 of theRect                 
    end if
 
-   if the visible of group "dgHorizontalComponents" of me then
-      put the top of scrollbar "dgHScrollbar" of group "dgHorizontalComponents" of me into item 4 of theRect
-   else
-      put item 4 of theViewRect - the dgProps["scrollbar corner offset"] of me into item 4 of theRect
+   if the environment is not "mobile" then
+      ## Reposition bottom element
+      local theSBWidth
+      if the visible of tVScrollbar then 
+         put the width of tVScrollbar into theSBWidth
+      else 
+         put the dgProps["scrollbar corner offset"] of me into theSBWidth
+      end if
+      # If the hscrollbar is not shown, then the horizontal components group
+      # containing it is invisible, so the corner piece is also invisible.
+      # So we can just set visibility of corner piece to the visible of the 
+      # vscrollbar
+      set the visible of tCornerPiece to the visible of tVScrollbar
+      
+      set the rect of tHScrollbar to \
+            item 1 of theRect, \
+            item 4 of theRect - the height of tHScrollbar, \
+            item 3 of theRect - theSBWidth, item 4 of theRect
+      
+      if the visible of tHorizontalComponents then
+         put the top of tHScrollbar into item 4 of theRect
+      else
+         put item 4 of theViewRect - the dgProps["scrollbar corner offset"] of me \
+               into item 4 of theRect
+      end if
+      
+      ## V Scrollbar and corner piece    
+      set the rect of tVScrollbar to \
+            item 3 of theRect - the width of tVScrollbar, \
+            item 2 of theRect, item 3 of theRect, \
+            item 4 of theRect
+      
+      set the rect of tCornerPiece to \
+            item 3 of theRect - the width of tVScrollbar, \
+            the top of tHScrollbar, \
+            item 3 of theRect, \
+            the bottom of tHScrollbar
+      
+      ## Masks
+      ## AL-2013-07-30 [[ Bug 10108 ]]  Thumb and scrollbar appear over top of DataGrid
+      if the visible of tVScrollbar then 
+         put item 3 of theRect - theSBWidth into item 3 of theRect
+      end if
+   else if __HasMobileScroller() then
+      mobileControlSet sScrollerId, "rect", theRect
    end if
 
-   ## V Scrollbar and corner piece    
-   set the rect of scrollbar "dgScrollbar" of me to item 3 of theRect - the width of scrollbar "dgScrollbar" of me, \
-         item 2 of theRect, item 3 of theRect, \
-         item 4 of theRect
-   
-   set the rect of graphic "dgCornerPiece" of group "dgHorizontalComponents" of me to \
-         item 3 of theRect - the width of scrollbar "dgScrollbar" of me, \
-         the top of scrollbar "dgHScrollbar" of group "dgHorizontalComponents" of me, item 3 of theRect, \
-         the bottom of scrollbar "dgHScrollbar" of group "dgHorizontalComponents" of me
-   
-   ## Masks
-   ## AL-2013-07-30 [[ Bug 10108 ]]  Thumb and scrollbar appear over top of DataGrid
-   if the visible of scrollbar "dgScrollbar" of me then put item 3 of theRect - theSBWidth into item 3 of theRect
    set the topLeft of group "dgListMask" of me to item 1 to 2 of theRect
    set the rect of group "dgListMask" of me to theRect
    set the rect of group "dgAlternatingRowsMask" of me to theRect

Toolset/palettes/standalone settings/revstandalonesettings.8.rev

@@ -0,0 +1 @@
+# Ensure Dictionary responds to cmd+W shortcut 

notes/bugfix-20647.md

@@ -0,0 +1 @@
+# Fix the display of errors thrown by the throw command in the script editor

notes/bugfix-21093.md

@@ -0,0 +1 @@
+# Ensure extensions required by the IDE load on startup