linter issues

Author: euri10

docs/examples/usage/test_configuration_10.py

@@ -1,6 +1,9 @@
+POOL_INSTANCE = 20
+
+
 def test_manual_pool() -> None:
     from sqlspec.adapters.asyncpg import AsyncpgConfig
 
-    pool = {"dsn": "postgresql://localhost/db", "min_size": 10, "max_size": 20}
+    pool = {"dsn": "postgresql://localhost/db", "min_size": 10, "max_size": POOL_INSTANCE}
     db = AsyncpgConfig(pool_instance=pool)
-    assert db.pool_instance["max_size"] == 20
+    assert db.pool_instance["max_size"] == POOL_INSTANCE

docs/examples/usage/test_configuration_15.py

@@ -1,5 +1,7 @@
 """Test configuration example: Global cache configuration."""
 
+SQL_CACHE_SIZE = 1000
+
 
 def test_global_cache_config() -> None:
     """Test global cache configuration."""
@@ -10,12 +12,12 @@ def test_global_cache_config() -> None:
         sql_cache_enabled=True,  # Cache SQL strings
         fragment_cache_enabled=True,  # Cache SQL fragments
         optimized_cache_enabled=True,  # Cache optimized AST
-        sql_cache_size=1000,  # Maximum cached SQL items
+        sql_cache_size=SQL_CACHE_SIZE,  # Maximum cached SQL items
     )
 
     # Update global cache configuration
     update_cache_config(cache_config)
 
     # Verify config applied
     assert cache_config.sql_cache_enabled is True
-    assert cache_config.sql_cache_size == 1000
+    assert cache_config.sql_cache_size == SQL_CACHE_SIZE

docs/examples/usage/test_configuration_23.py

@@ -32,6 +32,9 @@ def test_extension_config() -> None:
     }
 
 
+POSTGRES_PORT = 5433
+
+
 @pytest.mark.skipif(os.getenv("TEST_ASYNCPG", "0") != "1", reason="AsyncPG integration tests disabled")
 def test_environment_based_configuration() -> None:
     """Test environment-based configuration pattern."""
@@ -59,7 +62,7 @@ def test_environment_based_configuration() -> None:
         )
 
         assert config.pool_config["host"] == "testhost"
-        assert config.pool_config["port"] == 5433
+        assert config.pool_config["port"] == POSTGRES_PORT
         assert config.pool_config["user"] == "testuser"
         assert config.pool_config["password"] == "testpass"
         assert config.pool_config["database"] == "testdb"

docs/examples/usage/test_configuration_24.py

@@ -2,6 +2,9 @@
 
 import pytest
 
+MIN_POOL_SIZE = 10
+MAX_POOL_SIZE = 20
+
 
 @pytest.mark.skipif(
     not pytest.importorskip("asyncpg", reason="AsyncPG not installed"), reason="AsyncPG integration tests disabled"
@@ -10,8 +13,10 @@ def test_connection_pooling_best_practice() -> None:
     """Test connection pooling best practice configuration."""
     from sqlspec.adapters.asyncpg import AsyncpgConfig
 
-    config = AsyncpgConfig(pool_config={"dsn": "postgresql://localhost/db", "min_size": 10, "max_size": 20})
+    config = AsyncpgConfig(
+        pool_config={"dsn": "postgresql://localhost/db", "min_size": MIN_POOL_SIZE, "max_size": MAX_POOL_SIZE}
+    )
 
-    assert config.pool_config["min_size"] == 10
-    assert config.pool_config["max_size"] == 20
+    assert config.pool_config["min_size"] == MIN_POOL_SIZE
+    assert config.pool_config["max_size"] == MAX_POOL_SIZE
     assert config.supports_connection_pooling is True

docs/examples/usage/test_configuration_26.py

@@ -1,18 +1,23 @@
 """Test configuration example: Best practice - Tune pool sizes."""
 
+MIN_POOL_SIZE_CPU = 5
+MAX_POOL_SIZE_CPU = 10
+MIN_IO_BOUND_POOL_SIZE = 20
+MAX_IO_BOUND_POOL_SIZE = 50
+
 
 def test_tune_pool_sizes_best_practice() -> None:
     """Test pool sizing best practices for different workloads."""
 
     # CPU-bound workload - smaller pool
-    cpu_bound_pool_config = {"min_size": 5, "max_size": 10}
-    assert cpu_bound_pool_config["min_size"] == 5
-    assert cpu_bound_pool_config["max_size"] == 10
+    cpu_bound_pool_config = {"min_size": MIN_POOL_SIZE_CPU, "max_size": MAX_POOL_SIZE_CPU}
+    assert cpu_bound_pool_config["min_size"] == MIN_POOL_SIZE_CPU
+    assert cpu_bound_pool_config["max_size"] == MAX_POOL_SIZE_CPU
 
     # I/O-bound workload - larger pool
-    io_bound_pool_config = {"min_size": 20, "max_size": 50}
-    assert io_bound_pool_config["min_size"] == 20
-    assert io_bound_pool_config["max_size"] == 50
+    io_bound_pool_config = {"min_size": MIN_IO_BOUND_POOL_SIZE, "max_size": MAX_IO_BOUND_POOL_SIZE}
+    assert io_bound_pool_config["min_size"] == MIN_IO_BOUND_POOL_SIZE
+    assert io_bound_pool_config["max_size"] == MAX_IO_BOUND_POOL_SIZE
 
 
 def test_disable_security_checks_best_practice() -> None:

docs/examples/usage/test_configuration_6.py

@@ -1,10 +1,13 @@
+MYSQL_PORT = 3306
+
+
 def test_asyncmy_config_setup() -> None:
     from sqlspec.adapters.asyncmy import AsyncmyConfig
 
     config = AsyncmyConfig(
         pool_config={
             "host": "localhost",
-            "port": 3306,
+            "port": MYSQL_PORT,
             "user": "myuser",
             "password": "mypassword",
             "database": "mydb",
@@ -14,4 +17,4 @@ def test_asyncmy_config_setup() -> None:
             "pool_recycle": 3600,
         }
     )
-    assert config.pool_config["port"] == 3306
+    assert config.pool_config["port"] == MYSQL_PORT

docs/examples/usage/test_configuration_8.py

@@ -1,3 +1,6 @@
+MIN_POOL_SIZE = 10
+
+
 def test_asyncpg_pool_setup() -> None:
     from sqlspec.adapters.asyncpg import AsyncpgConfig
 
@@ -10,4 +13,4 @@ def test_asyncpg_pool_setup() -> None:
             "max_inactive_connection_lifetime": 300.0,
         }
     )
-    assert config.pool_config["min_size"] == 10
+    assert config.pool_config["min_size"] == MIN_POOL_SIZE

docs/examples/usage/test_configuration_9.py

@@ -3,5 +3,5 @@ def test_pool_lifecycle() -> None:
     from sqlspec.adapters.asyncpg import AsyncpgConfig
 
     spec = SQLSpec()
-    db = spec.add_config(AsyncpgConfig(pool_config={"dsn": "postgresql://localhost/db"}))
+    spec.add_config(AsyncpgConfig(pool_config={"dsn": "postgresql://localhost/db"}))
     assert spec.configs[AsyncpgConfig].pool_config["dsn"] == "postgresql://localhost/db"