-
Notifications
You must be signed in to change notification settings - Fork 589
panel-copy@mostlynick3: Add new applet #8034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This doesn't check to see if an applet is multi instance before copying it. The following default applets are single instance: inhibit, network, notifications, on-screen-keyboard, power, slideshow, sound, systray, xrandr. I don't know why all these are single instance but presumably one or both instances will not work correctly. For instance, with the notifications applet, the notifications will only appear in one of the instances. Many 3rd party applets are also single instance. |
|
Thanks for your comment, @fredcw - I haven't tested all single instance applets but haven't found any issues with network, power, sound, systray, or inhibit. These applets work identically across all panels with the applet. My goal with this applet is to add identical panels to secondary monitors, so I can fully manage my system no matter which monitor's dock I'm using. Seeing as I don't have any issues with the single instance applets I use, I would prefer not to exclude them altogether. With your comment in mind, I believe it would then be most reasonable to add a config setting to enable or disable cloning single instance applets. What do you think? |
|
I just tried copying a panel with your applet and cinnamon crashed. I think if an applet is single instance, it's probably because there's a good reason and copying it anyway could cause system instability or crashes. Some of the default applets may be easy to make multi-instance or not, I'm not sure. One thing I noticed is that with the inhibit applet, turning off/on power management in one instance does not flip the switch in the other instance. Also, with systray applet, I have clipIt app, but it only appears in one of the instances. The sound applet also disappeared from both panels. I think it's too risky to copy all single instance applets. |
|
I've now barred single instance applets from being copied, would very much appreciate it if you could give it another go @fredcw! |
|
Yeah that works great except for some 3rd party applets e.g. sysmonitor@orcus because it's looking for metadata.json file in the versioned directory "3.2" Also, I get this in ~/.xsession-errors maybe try JS's TextDecoder? |
Adds an applet that lets users copy their panels to new locations or monitors. Tested on Cinnamon 6.x