-
Notifications
You must be signed in to change notification settings - Fork 5
Show more request context in the UI (fix #69) #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Show more request context in the UI (fix #69) #105
Conversation
|
As discussed in the past, totally agree on adding the caller identity. I appreciate this is a reference implementation, but IMO there's value in bringing our recommendations/best practices on wording, hence sharing a bit more feedback:
How about something like:
And:
Figmas for other platforms from passkeycentral.org. @msirringhaus, @iinuwa, WDYT? @timcappalli I don't know of any published guidelines for platforms, but would be curious to hear your thoughts if you have any, or if you know someone who might. |
9945cd6 to
dec5b0f
Compare
…lly up to a given limit instead of giving them a big minimal height
|
@AlfioEmanueleFresta I think your proposed UI/text makes sense and nicely aligns with other experiences in the ecosystem, while also addressing unique considerations for Linux (showing process ID in addition to name). |

Note: This is based on the translations-PR to utilize translatable strings here, too. So for now, only look at the last commit.
Points of contention:
/proc/PID/commis used for the application name, instead of the full absolute path to the binary. I think the full path may confuse more than help novice users, but I'm open to change that.If we stay with the current proposal, I would need to add more translations-metadata to make it clear to potential translators how the new strings are used.