Merge pull request #386 from linkml/no_merge_create_fn

emit warnings for python 3.13

Author: sierra-moxon

linkml_runtime/utils/dataclass_extensions_376.py

@@ -1,30 +1,15 @@
+import sys
+import warnings
 import dataclasses
-#
-# The dataclass library builds a rigid `__init__` function that doesn't allow any unrecognized named parameters
-#
-# The purpose of this extension is to enhance the library to allow additional keyword arguments to passed in
-# and then on to the __post_init__ function that can deal with them accordingly
 
-# Beware that there is no promise that signature of the create function will remain consistent
-loc_fn = dataclasses._create_fn
+warnings.warn(
+    "The LinkML dataclass extension patch is deprecated and will be removed in a future release.\n"
+    "If you're currently using Python < 3.13, where this patch still applies, you should:\n"
+    "  • Upgrade your LinkML tooling to version >= 1.9.0 (which no longer needs this patch), OR\n"
+    "  • Migrate to Pydantic models if you're using LinkML's generated classes at runtime.\n",
+    DeprecationWarning,
+    stacklevel=2
+)
 
-
-def dc_create_fn(name, args, body, *_posargs, **_kwargs):
-    # If overriding the initializer and using a post init
-    if name == '__init__' and dataclasses._POST_INIT_NAME in body[-1]:
-        # Then insert the kwargs into the both the call and the post init
-        pi_parms = body[-1].rsplit(')', 1)[0]
-        body[-1] = pi_parms + ('' if pi_parms[-1] == '(' else ',') + ' **_kwargs)'
-        return loc_fn(name, list(args) + ["**_kwargs"], body, *_posargs, **_kwargs)
-    else:
-        return loc_fn(name, args, body, *_posargs, **_kwargs)
-
-
-dataclasses._create_fn = dc_create_fn
-
-# The following line is here solely to be backwards compatible.
 dataclasses_init_fn_with_kwargs = dataclasses._init_fn
-
-# The following line can be used to make certain that the import of the new create function doesn't get
-# discarded as being potentially unused
-DC_CREATE_FN = True
+DC_CREATE_FN = False

poetry.lock

@@ -0,0 +1,27 @@
+import sys
+import pytest
+import importlib.util
+import dataclasses
+
+
+def import_patch_module():
+    """Fresh import to ensure warning is triggered"""
+    spec = importlib.util.find_spec("linkml_runtime.utils.dataclass_extensions_376")
+    mod = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(mod)
+    return mod
+
+def test_patch_module_emits_deprecation_warning():
+    """All Python versions: emits DeprecationWarning and defines compatibility symbols"""
+    with pytest.warns(DeprecationWarning):
+        mod = import_patch_module()
+
+    assert hasattr(mod, "DC_CREATE_FN")
+    assert hasattr(mod, "dataclasses_init_fn_with_kwargs")
+    assert mod.DC_CREATE_FN is False
+
+    # Check consistency with actual dataclasses module
+    init_fn = getattr(dataclasses, "_init_fn", None)
+    assert mod.dataclasses_init_fn_with_kwargs == init_fn
+
+