Skip to content

Commit ea9c1b7

Browse files
add running on an approving review
don't specify linkml-runtime repository so it works on pull requests
1 parent dad8f20 commit ea9c1b7

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

.github/workflows/test-upstream.yaml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
name: Test with upstream linkml
22
on:
3+
pull_request_review:
4+
types: [ submitted ]
35
workflow_dispatch:
46

57
jobs:
68
test_upstream:
9+
if: github.event_name == 'workflow_dispatch' || github.event.review.state == 'APPROVED'
710
strategy:
8-
fail-fast: false
911
matrix:
1012
os: [ ubuntu-latest, windows-latest ]
1113
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
@@ -24,17 +26,20 @@ jobs:
2426
runs-on: ${{ matrix.os }}
2527

2628
steps:
29+
2730
- name: checkout upstream
2831
uses: actions/checkout@v4
2932
with:
3033
repository: linkml/linkml
3134
path: linkml
35+
ref: main
3236
fetch-depth: 0
3337

3438
- name: checkout linkml-runtime
3539
uses: actions/checkout@v4
3640
with:
37-
repository: linkml/linkml-runtime
41+
# don't specify repository like this or else we won't get pull request branches correctly
42+
# repository: linkml/linkml-runtime
3843
path: linkml-runtime
3944
fetch-depth: 0
4045

0 commit comments

Comments
 (0)