Skip to content

Commit d32c92c

Browse files
author
Gyeongil Goo
authored
Merge pull request #22 from line/develop/v1.1.0
Develop/v1.1.0
2 parents 53bd487 + f78ad6c commit d32c92c

File tree

19 files changed

+494
-70
lines changed

19 files changed

+494
-70
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
---
22
name: Bug report
33
about: Create a report to help us improve
4-
title: ''
5-
labels: ''
6-
assignees: ''
4+
title: "[plugin-name] Summary of the bug you found"
5+
labels: bug
6+
assignees: yuinacor
77

88
---
99

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
name: Feature request
33
about: Suggest an idea for this project
44
title: ''
5-
labels: ''
6-
assignees: ''
5+
labels: enhancement
6+
assignees: yuinacor
77

88
---
99

.github/workflows/publish.yml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
name: Gradle Plugin Publish
2+
on:
3+
release:
4+
types:
5+
- published
6+
7+
jobs:
8+
publish:
9+
runs-on: ubuntu-latest
10+
name: Publish plugin to gradle plugins portal
11+
steps:
12+
- uses: actions/checkout@v2
13+
- name: Set up JDK 12
14+
uses: actions/setup-java@v1
15+
with:
16+
java-version: 12
17+
- name: Grant execute permission for gradlew
18+
run: chmod +x gradlew
19+
- run: cat ./gradle.properties
20+
- name: Publish plugins with gradle
21+
env:
22+
GRADLE_PUBLISH_KEY: ${{ secrets.GRADLE_PUBLISH_KEY }}
23+
GRADLE_PUBLISH_SECRET: ${{ secrets.GRADLE_PUBLISH_SECRET }}
24+
run: ./gradlew publishPlugins -Pgradle.publish.key=$GRADLE_PUBLISH_KEY -Pgradle.publish.secret=$GRADLE_PUBLISH_SECRET

.github/workflows/pull-request.yml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
name: Java CI
2+
3+
on: [pull_request]
4+
5+
jobs:
6+
build:
7+
runs-on: ${{matrix.os}}
8+
strategy:
9+
matrix:
10+
java: [8, 9, 10, 11, 12]
11+
os: [ubuntu-latest, macos-latest, windows-latest]
12+
name: java ${{matrix.java}} runner over ${{matrix.os}}
13+
steps:
14+
- uses: actions/checkout@v2
15+
- name: Set up JDK ${{matrix.java}}
16+
uses: actions/setup-java@v1
17+
with:
18+
java-version: ${{matrix.java}}
19+
- name: Grant execute permission for gradlew
20+
run: chmod +x gradlew
21+
- name: Check with Gradle
22+
run: ./gradlew check --parallel --no-daemon
23+
- uses: actions/upload-artifact@v1
24+
if: failure()
25+
with:
26+
name: ${{matrix.os}}_${{matrix.java}}
27+
path: "./"

.gitmodules

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
[submodule "sample"]
2+
path = recursive-git-log-plugin/src/test/resources/sample
3+
url = https://github.com/line/gradle-multi-project-support-sample.git
4+
branch = master

build-recipe-plugin/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# Build Recipe Plugin
22

3+
[![Gradle Plugin Portal](https://img.shields.io/maven-metadata/v/https/plugins.gradle.org/m2/com/linecorp/build-recipe-plugin/com.linecorp.build-recipe-plugin.gradle.plugin/maven-metadata.xml.svg?colorB=007ec6&label=Gradle%20Plugin%20Portal)](https://plugins.gradle.org/plugin/com.linecorp.build-recipe-plugin)
4+
35
A Gradle plugin which makes your build configuration **reusable** and **centralized**.
46

57
We were strongly inspired by [Armeria's build scripts](https://github.com/line/armeria/tree/master/gradle/scripts).

build-recipe-plugin/build.gradle.kts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@ gradlePlugin {
2222
implementationClass = "com.linecorp.support.project.multi.recipe.BuildRecipePlugin"
2323
}
2424
}
25-
26-
dependencies {
27-
testImplementation("io.mockk:mockk:1.8.13")
28-
testImplementation("com.willowtreeapps.assertk:assertk-jvm:0.19")
29-
}
3025
}
3126

3227
pluginBundle {

build-recipe-plugin/src/test/kotlin/com/linecorp/support/project/multi/recipe/FunctionalTest.kt

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@
1717
package com.linecorp.support.project.multi.recipe
1818

1919
import assertk.assertThat
20-
import assertk.assertions.isTrue
20+
import assertk.assertions.contains
21+
import org.gradle.kotlin.dsl.support.normaliseLineSeparators
2122
import org.gradle.testkit.runner.GradleRunner
2223
import org.junit.jupiter.api.Test
2324
import java.nio.file.Paths
@@ -69,7 +70,7 @@ project ':juice:api:protocol' is configured by
6970
project ':juice:api:server' is configured by
7071
- type prefix [java]
7172
- type having [boot]
72-
- type suffix [boot-application]""".trimIndent()
73+
- type suffix [boot-application]""".trimIndent().normaliseLineSeparators()
7374

7475
@Test
7576
fun `kotlin dsl test`() {
@@ -78,11 +79,11 @@ project ':juice:api:server' is configured by
7879
GradleRunner.create()
7980
.withProjectDir(file.toFile())
8081
.withPluginClasspath()
81-
.withArguments("allProjectReport", "--stacktrace")
82-
.withGradleVersion("5.5.1")
82+
.withArguments("allProjectReport")
8383
.build()
8484
.also { println(it.output) }
85-
.also { assertThat(it.output.contains(expected)).isTrue() }
85+
.let { it.output.normaliseLineSeparators() }
86+
.also { assertThat(it).contains(expected) }
8687
}
8788

8889
@Test
@@ -92,10 +93,10 @@ project ':juice:api:server' is configured by
9293
GradleRunner.create()
9394
.withProjectDir(file.toFile())
9495
.withPluginClasspath()
95-
.withArguments("allProjectReport", "--stacktrace")
96-
.withGradleVersion("5.5.1")
96+
.withArguments("allProjectReport")
9797
.build()
9898
.also { println(it.output) }
99-
.also { assertThat(it.output.contains(expected)).isTrue() }
99+
.let { it.output.normaliseLineSeparators() }
100+
.also { assertThat(it).contains(expected) }
100101
}
101102
}

build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ configure(byTypeSuffix("gradle-plugin") and byLabel("junit5-platform")) {
9292
testImplementation("org.junit.jupiter:junit-jupiter-params:5.5.1")
9393

9494
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:5.5.1")
95+
testImplementation("io.mockk:mockk:1.9.3")
96+
testImplementation("com.willowtreeapps.assertk:assertk-jvm:0.21")
9597
}
9698

9799
tasks {

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@
1515
#
1616
kotlin.code.style=official
1717
group=com.linecorp.support.project.multi
18-
version=1.0.2-SNAPSHOT
18+
version=1.1.1

0 commit comments

Comments
 (0)