Hostpath mount validation #4419
Open
+125
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Praful Khanduri <holiodin@gmail.com>
Horiodino
force-pushed
the
hostPath_mount_validation
branch
from
75f0a14 to
84ff74e
Compare
AkihiroSuda
reviewed
Dec 1, 2025
pkg/mcp/toolset/toolset.go
Outdated
| } | ||
| // TODO: make sure that hostPath is mounted | ||
| if !ts.isMounted(hostPath) { | ||
| return "", fmt.Errorf("path %q is not mounted", hostPath) |
Member
There was a problem hiding this comment.
Callers such as ListDirectory and ReadFile have to handle this case.
Probably it should fall back to the guest path, with an annotation in the tool result to indicate how the path was resolved.
Signed-off-by: Praful Khanduri <holiodin@gmail.com>
Horiodino
force-pushed
the
hostPath_mount_validation
branch
from
84ff74e to
c44939c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
added validation to ensure
hostPathis part of a configured mount. if the path is not mounted, an error is returned.Testing:
added unit tests for
isMounted