Merge pull request #2301 from BajuMcBites/fix-error-on-ls

limactl ls $INSTANCE should exit with non-0 status if $INSTANCE does not exist #1139 #2295

Author: jandubois

cmd/limactl/list.go

@@ -124,13 +124,15 @@ func listAction(cmd *cobra.Command, args []string) error {
 	}
 
 	instanceNames := []string{}
+	unmatchedInstances := false
 	if len(args) > 0 {
 		for _, arg := range args {
 			matches := instanceMatches(arg, allinstances)
 			if len(matches) > 0 {
 				instanceNames = append(instanceNames, matches...)
 			} else {
-				return fmt.Errorf("no instance matching %v found", arg)
+				logrus.Warnf("No instance matching %v found.", arg)
+				unmatchedInstances = true
 			}
 		}
 	} else {
@@ -141,6 +143,9 @@ func listAction(cmd *cobra.Command, args []string) error {
 		for _, instName := range instanceNames {
 			fmt.Fprintln(cmd.OutOrStdout(), instName)
 		}
+		if unmatchedInstances {
+			os.Exit(1)
+		}
 		return nil
 	}
 
@@ -174,7 +179,12 @@ func listAction(cmd *cobra.Command, args []string) error {
 			}
 		}
 	}
-	return store.PrintInstances(out, instances, format, &options)
+
+	err = store.PrintInstances(out, instances, format, &options)
+	if err == nil && unmatchedInstances {
+		os.Exit(1)
+	}
+	return err
 }
 
 func listBashComplete(cmd *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {