Merge pull request #2522 from alexandear/fix-add-missing-file-close

Add missing file.Close() method calls

Author: AkihiroSuda

pkg/editutil/editutil.go

@@ -64,6 +64,7 @@ func OpenEditor(content []byte, hdr string) ([]byte, error) {
 	tmpYAMLPath := tmpYAMLFile.Name()
 	defer os.RemoveAll(tmpYAMLPath)
 	if _, err := tmpYAMLFile.Write(append([]byte(hdr), content...)); err != nil {
+		tmpYAMLFile.Close()
 		return nil, err
 	}
 	if err := tmpYAMLFile.Close(); err != nil {

pkg/qemu/entitlementutil/entitlementutil.go

@@ -51,6 +51,7 @@ func Sign(qExe string) error {
   </dict>
 </plist>`
 	if _, err = ent.WriteString(entXML); err != nil {
+		ent.Close()
 		return fmt.Errorf("failed to write to a temporary file %q for signing QEMU binary: %w", entName, err)
 	}
 	ent.Close()

pkg/wsl2/vm_windows.go

@@ -81,6 +81,7 @@ func provisionVM(ctx context.Context, instanceDir, instanceName, distroName stri
 		return err
 	}
 	if _, err = limaBootFile.Write(limaBootB); err != nil {
+		limaBootFile.Close()
 		return err
 	}
 	limaBootFileWinPath := limaBootFile.Name()

pkg/yqutil/yqutil.go

@@ -22,6 +22,7 @@ func EvaluateExpression(expression string, content []byte) ([]byte, error) {
 	defer os.RemoveAll(tmpYAMLPath)
 	_, err = tmpYAMLFile.Write(content)
 	if err != nil {
+		tmpYAMLFile.Close()
 		return nil, err
 	}
 	if err = tmpYAMLFile.Close(); err != nil {