Skip to content

Commit 46b8def

Browse files
Merge pull request #252 from lightpanda-io/ci-cache-key-v8
ci: add zig v8 version into the cache key
2 parents 31d188d + d639e87 commit 46b8def

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

.github/actions/install/action.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ runs:
3737

3838
- name: Cache v8
3939
id: cache-v8
40-
uses: actions/cache@v3
40+
uses: actions/cache@v4
4141
env:
4242
cache-name: cache-v8
4343
with:
4444
path: ${{ inputs.cache-dir }}/v8
45-
key: libc_v8_${{ inputs.v8 }}_${{ inputs.os }}_${{ inputs.arch }}.a
45+
key: libc_v8_${{ inputs.v8 }}_${{ inputs.os }}_${{ inputs.arch }}_${{ inputs.zig-v8 }}.a
4646

4747
- if: ${{ steps.cache-v8.outputs.cache-hit != 'true' }}
4848
shell: bash
@@ -51,6 +51,9 @@ runs:
5151
5252
wget -O ${{ inputs.cache-dir }}/v8/libc_v8.a https://github.com/lightpanda-io/zig-v8-fork/releases/download/${{ inputs.zig-v8 }}/libc_v8_${{ inputs.v8 }}_${{ inputs.os }}_${{ inputs.arch }}.a
5353
54+
- run: sudo apt-get install -yq libglib2.0-dev
55+
shell: bash
56+
5457
- name: install v8
5558
shell: bash
5659
run: |

.github/workflows/benchmark.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
benchmark:
3535
name: benchmark
3636

37-
runs-on: ubuntu-latest
37+
runs-on: ubuntu-24.04
3838

3939
# Don't run the CI with draft PR.
4040
if: github.event.pull_request.draft == false
@@ -79,7 +79,7 @@ jobs:
7979
# Don't execute on PR
8080
if: github.event_name != 'pull_request'
8181

82-
runs-on: ubuntu-latest
82+
runs-on: ubuntu-24.04
8383
container:
8484
image: ghcr.io/lightpanda-io/perf-fmt:latest
8585
credentials:

.github/workflows/zig-fmt.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
# Don't run the CI with draft PR.
3030
if: github.event.pull_request.draft == false
3131

32-
runs-on: ubuntu-latest
32+
runs-on: ubuntu-24.04
3333

3434
steps:
3535
- uses: mlugg/setup-zig@v1

.github/workflows/zig-test.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
# Don't run the CI with draft PR.
3636
if: github.event.pull_request.draft == false
3737

38-
runs-on: ubuntu-latest
38+
runs-on: ubuntu-24.04
3939

4040
steps:
4141
- uses: actions/checkout@v4
@@ -54,10 +54,10 @@ jobs:
5454
# Don't run the CI with draft PR.
5555
if: github.event.pull_request.draft == false
5656

57-
runs-on: ubuntu-latest
57+
runs-on: ubuntu-24.04
5858

5959
steps:
60-
- uses: actions/checkout@v3
60+
- uses: actions/checkout@v4
6161
with:
6262
fetch-depth: 0
6363
submodules: true
@@ -73,7 +73,7 @@ jobs:
7373
# Don't run the CI with draft PR.
7474
if: github.event.pull_request.draft == false
7575

76-
runs-on: ubuntu-latest
76+
runs-on: ubuntu-24.04
7777

7878
steps:
7979
- uses: actions/checkout@v4

0 commit comments

Comments
 (0)