Skip to content

Commit d4d3567

Browse files
committed
prefer call_arena in web APIs
1 parent 7d39bc9 commit d4d3567

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

src/browser/html/elements.zig

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ pub const HTMLAnchorElement = struct {
284284
var u = try url(self, page);
285285
defer u.destructor();
286286

287-
return page.arena.dupe(u8, u.get_protocol());
287+
return page.call_arena.dupe(u8, u.get_protocol());
288288
}
289289

290290
pub fn set_protocol(self: *parser.Anchor, protocol: []const u8, page: *Page) !void {
@@ -301,7 +301,7 @@ pub const HTMLAnchorElement = struct {
301301
var u = url(self, page) catch return "";
302302
defer u.destructor();
303303

304-
return page.arena.dupe(u8, u.get_host());
304+
return page.call_arena.dupe(u8, u.get_host());
305305
}
306306

307307
pub fn set_host(self: *parser.Anchor, host: []const u8, page: *Page) !void {
@@ -316,7 +316,7 @@ pub const HTMLAnchorElement = struct {
316316
pub fn get_hostname(self: *parser.Anchor, page: *Page) ![]const u8 {
317317
var u = url(self, page) catch return "";
318318
defer u.destructor();
319-
return page.arena.dupe(u8, u.get_hostname());
319+
return page.call_arena.dupe(u8, u.get_hostname());
320320
}
321321

322322
pub fn set_hostname(self: *parser.Anchor, hostname: []const u8, page: *Page) !void {
@@ -332,7 +332,7 @@ pub const HTMLAnchorElement = struct {
332332
pub fn get_port(self: *parser.Anchor, page: *Page) ![]const u8 {
333333
var u = url(self, page) catch return "";
334334
defer u.destructor();
335-
return page.arena.dupe(u8, u.get_port());
335+
return page.call_arena.dupe(u8, u.get_port());
336336
}
337337

338338
pub fn set_port(self: *parser.Anchor, maybe_port: ?[]const u8, page: *Page) !void {
@@ -359,7 +359,7 @@ pub const HTMLAnchorElement = struct {
359359
return "";
360360
}
361361

362-
return page.arena.dupe(u8, username);
362+
return page.call_arena.dupe(u8, username);
363363
}
364364

365365
pub fn set_username(self: *parser.Anchor, maybe_username: ?[]const u8, page: *Page) !void {
@@ -378,7 +378,7 @@ pub const HTMLAnchorElement = struct {
378378
var u = url(self, page) catch return "";
379379
defer u.destructor();
380380

381-
return page.arena.dupe(u8, u.get_password());
381+
return page.call_arena.dupe(u8, u.get_password());
382382
}
383383

384384
pub fn set_password(self: *parser.Anchor, maybe_password: ?[]const u8, page: *Page) !void {
@@ -397,7 +397,7 @@ pub const HTMLAnchorElement = struct {
397397
var u = url(self, page) catch return "";
398398
defer u.destructor();
399399

400-
return page.arena.dupe(u8, u.get_pathname());
400+
return page.call_arena.dupe(u8, u.get_pathname());
401401
}
402402

403403
pub fn set_pathname(self: *parser.Anchor, pathname: []const u8, page: *Page) !void {
@@ -431,7 +431,7 @@ pub const HTMLAnchorElement = struct {
431431
var u = url(self, page) catch return "";
432432
defer u.destructor();
433433

434-
return page.arena.dupe(u8, u.get_hash());
434+
return page.call_arena.dupe(u8, u.get_hash());
435435
}
436436

437437
pub fn set_hash(self: *parser.Anchor, maybe_hash: ?[]const u8, page: *Page) !void {

src/browser/url/url.zig

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,6 @@ pub const URL = struct {
144144
}
145145

146146
pub fn get_origin(self: *const URL, page: *Page) ![]const u8 {
147-
const arena = page.arena;
148147
// `ada.getOriginNullable` allocates memory in order to find the `origin`.
149148
// We'd like to use our arena allocator for such case;
150149
// so here we allocate the `origin` in page arena and free the original.
@@ -155,7 +154,7 @@ pub const URL = struct {
155154
defer ada.freeOwnedString(maybe_origin);
156155

157156
const origin = maybe_origin.data[0..maybe_origin.length];
158-
return arena.dupe(u8, origin);
157+
return page.call_arena.dupe(u8, origin);
159158
}
160159

161160
pub fn get_href(self: *const URL, page: *Page) ![]const u8 {

0 commit comments

Comments
 (0)