From b9649148420e7be89d78ed7fa91d8e48998606e1 Mon Sep 17 00:00:00 2001 From: Thiago Barcala Date: Wed, 19 Nov 2025 21:20:23 +0100 Subject: [PATCH 1/2] commands: improve UX for estimate fee command The RPC call expects a value different than 0 for conf_target. Since the command description says the parameter is optional, it makes sense to provide a default. --- cmd/commands/commands.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cmd/commands/commands.go b/cmd/commands/commands.go index fd8dc2092a1..b6deb958bdf 100644 --- a/cmd/commands/commands.go +++ b/cmd/commands/commands.go @@ -396,10 +396,11 @@ var estimateFeeCommand = cli.Command{ '{"ExampleAddr": NumCoinsInSatoshis, "SecondAddr": NumCoins}' `, Flags: []cli.Flag{ - cli.Int64Flag{ + cli.Uint64Flag{ Name: "conf_target", - Usage: "(optional) the number of blocks that the " + - "transaction *should* confirm in", + Usage: "the number of blocks that the transaction " + + "should be confirmed on-chain within", + Value: 6, }, coinSelectionStrategyFlag, }, From 829c75112e2dd2f341e32d03591583f896f23798 Mon Sep 17 00:00:00 2001 From: Thiago Barcala Date: Tue, 2 Dec 2025 19:42:20 +0100 Subject: [PATCH 2/2] Undo change in type of flag --- cmd/commands/commands.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/commands/commands.go b/cmd/commands/commands.go index b6deb958bdf..a7a8b6f2af5 100644 --- a/cmd/commands/commands.go +++ b/cmd/commands/commands.go @@ -396,7 +396,7 @@ var estimateFeeCommand = cli.Command{ '{"ExampleAddr": NumCoinsInSatoshis, "SecondAddr": NumCoins}' `, Flags: []cli.Flag{ - cli.Uint64Flag{ + cli.Int64Flag{ Name: "conf_target", Usage: "the number of blocks that the transaction " + "should be confirmed on-chain within",