sphinx: return ErrInvalidOnionKey if can't parse ephemeral

Roasbeef · Roasbeef · commit e1134370935c · 2017-09-13T13:48:51.000+02:00
diff --git a/sphinx.go b/sphinx.go
@@ -64,7 +64,7 @@ const (
 	keyLen = 32
 
 	// baseVersion represent the current supported version of onion packet.
-	baseVersion = 0
+	baseVersion = 1
 )
 
 var (
@@ -417,7 +417,7 @@ func (f *OnionPacket) Decode(r io.Reader) error {
 	}
 	f.EphemeralKey, err = btcec.ParsePubKey(ephemeral[:], btcec.S256())
 	if err != nil {
-		return err
+		return ErrInvalidOnionKey
 	}
 
 	if _, err := io.ReadFull(r, f.RoutingInfo[:]); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ const (`
`64`	`64`	`keyLen = 32`
`65`	`65`
`66`	`66`	`// baseVersion represent the current supported version of onion packet.`
`67`		`- baseVersion = 0`
	`67`	`+ baseVersion = 1`
`68`	`68`	`)`
`69`	`69`
`70`	`70`	`var (`
`@@ -417,7 +417,7 @@ func (f *OnionPacket) Decode(r io.Reader) error {`
`417`	`417`	`}`
`418`	`418`	`f.EphemeralKey, err = btcec.ParsePubKey(ephemeral[:], btcec.S256())`
`419`	`419`	`if err != nil {`
`420`		`- return err`
	`420`	`+ return ErrInvalidOnionKey`
`421`	`421`	`}`
`422`	`422`
`423`	`423`	`if _, err := io.ReadFull(r, f.RoutingInfo[:]); err != nil {`