Remove file logic from log action

Author: tanx

src/action/log.js

@@ -10,8 +10,6 @@ import { MAX_LOG_LENGTH } from '../config';
 let _store;
 let _ipc;
 let _printErrObj;
-let _FS;
-let _Share;
 
 /**
  * Log an info event e.g. when something relevant but non-critical happens.
@@ -51,49 +49,6 @@ export function error(...args) {
   _ipc && _ipc.send('log-error', null, args);
 }
 
-/**
- * Gets the location of the LND log file as a string.
- * @param {string} network The network the user's on
- * @return {string}
- */
-export function getLogPath(network) {
-  if (!_FS) {
-    throw new Error('Cannot get log path with no FS in action/log.js');
-  }
-  const lndDir = _FS.DocumentDirectoryPath;
-  return `${lndDir}/logs/bitcoin/${network}/lnd.log`;
-}
-
-/**
- * Retrieves the entire LND log file as a string.
- * @return {Promise<string>}
- */
-export async function getLogs() {
-  if (!_FS) {
-    throw new Error('Cannot get logs with no FS in action/log.js');
-  }
-  return _FS.readFile(getLogPath(_store.network), 'utf8');
-}
-
-/**
- * Shares the log file using whatever native share function we have.
- * @return {Promise}
- */
-export async function shareLogs() {
-  try {
-    if (!_Share) {
-      throw new Error('Cannot share logs with no Share in action/log.js');
-    }
-    const logs = await getLogs();
-    return _Share.share({
-      title: 'Lightning App logs',
-      message: logs,
-    });
-  } catch (err) {
-    error(err.message);
-  }
-}
-
 function pushLogs(message) {
   if (!_store) return;
   _store.logs += '\n' + message.replace(/\s+$/, '');
@@ -108,8 +63,6 @@ class LogAction {
     _store = store;
     _ipc = ipc;
     _printErrObj = printErrObj;
-    _FS = FS;
-    _Share = Share;
     _ipc.listen('logs', (event, message) => pushLogs(message));
     _ipc.send('logs-ready', null, true);
   }

test/unit/action/log.spec.js

@@ -9,22 +9,13 @@ describe('Action Logs Unit Tests', () => {
   let sandbox;
   let ipc;
   let ipcRenderer;
-  let RNFS;
-  let Share;
 
   beforeEach(() => {
     sandbox = sinon.createSandbox({});
     ipcRenderer = {
       send: sinon.stub(),
       on: sinon.stub().yields('some-event', 'some-arg'),
     };
-    RNFS = {
-      DocumentDirectoryPath: '/foo/bar',
-      readFile: sinon.stub().resolves('logs'),
-    };
-    Share = {
-      share: sinon.stub().resolves(true),
-    };
   });
 
   afterEach(() => {
@@ -124,41 +115,5 @@ describe('Action Logs Unit Tests', () => {
         expect(store.logs.length, 'to equal', 56);
       });
     });
-
-    describe('getLogPath()', () => {
-      it('should throw without a FS constructor argument', () => {
-        expect(() => log.getLogPath(), 'to throw');
-      });
-
-      it('should return a log path with FS constructor argument', () => {
-        new LogAction(store, ipc, false, RNFS);
-        expect(log.getLogPath(), 'to be a string');
-      });
-    });
-
-    describe('getLogs()', () => {
-      it('should throw without a FS constructor argument', async () => {
-        await expect(log.getLogs(), 'to be rejected');
-      });
-
-      it('should return logs with an FS constructor argument', async () => {
-        new LogAction(store, ipc, false, RNFS);
-        expect(await log.getLogs(), 'to be a string');
-        expect(RNFS.readFile.called, 'to be true');
-      });
-    });
-
-    describe('shareLogs()', () => {
-      it('should resolve false-y without Share or FS constructor arguments', async () => {
-        expect(await log.shareLogs(), 'not to be ok');
-      });
-
-      it('should share the logs with a Share and FS constructor argument', async () => {
-        new LogAction(store, ipc, false, RNFS, Share);
-        expect(await log.shareLogs(), 'to be ok');
-        expect(RNFS.readFile.called, 'to be true');
-        expect(Share.share.called, 'to be true');
-      });
-    });
   });
 });