Address clippy lints in remaining tests

In a coming commit we'll enable `clippy` linting in our test code.
Here we prepare for this by addressing the lints we'll enforce in
test code in remaining crates.

Author: TheBlueMatt

lightning-background-processor/src/lib.rs

@@ -2255,7 +2255,7 @@ mod tests {
 		get_event!(nodes[1], Event::ChannelPending);
 		let msg_1 = get_event_msg!(nodes[1], MessageSendEvent::SendFundingSigned, node_0_id);
 		nodes[0].node.handle_funding_signed(node_1_id, &msg_1);
-		let _ = channel_pending_recv
+		channel_pending_recv
 			.recv_timeout(Duration::from_secs(EVENT_DEADLINE))
 			.expect("ChannelPending not handled within deadline");
 

lightning-invoice/src/de.rs

@@ -1025,37 +1025,38 @@ mod test {
 			fqxu92d8lr6fvg0r5gv0heeeqgcrqlnm6jhphu9y00rrhy4grqszsvpcgpy9qqqqqqgqqqqq7qqzq".as_bytes()
 		);
 
-		let mut expected = Vec::<RouteHintHop>::new();
-		expected.push(RouteHintHop {
-			src_node_id: PublicKey::from_slice(
-				&[
-					0x02u8, 0x9e, 0x03, 0xa9, 0x01, 0xb8, 0x55, 0x34, 0xff, 0x1e, 0x92, 0xc4, 0x3c,
-					0x74, 0x43, 0x1f, 0x7c, 0xe7, 0x20, 0x46, 0x06, 0x0f, 0xcf, 0x7a, 0x95, 0xc3,
-					0x7e, 0x14, 0x8f, 0x78, 0xc7, 0x72, 0x55,
-				][..],
-			)
-			.unwrap(),
-			short_channel_id: 0x0102030405060708,
-			fees: RoutingFees { base_msat: 1, proportional_millionths: 20 },
-			cltv_expiry_delta: 3,
-			htlc_minimum_msat: None,
-			htlc_maximum_msat: None,
-		});
-		expected.push(RouteHintHop {
-			src_node_id: PublicKey::from_slice(
-				&[
-					0x03u8, 0x9e, 0x03, 0xa9, 0x01, 0xb8, 0x55, 0x34, 0xff, 0x1e, 0x92, 0xc4, 0x3c,
-					0x74, 0x43, 0x1f, 0x7c, 0xe7, 0x20, 0x46, 0x06, 0x0f, 0xcf, 0x7a, 0x95, 0xc3,
-					0x7e, 0x14, 0x8f, 0x78, 0xc7, 0x72, 0x55,
-				][..],
-			)
-			.unwrap(),
-			short_channel_id: 0x030405060708090a,
-			fees: RoutingFees { base_msat: 2, proportional_millionths: 30 },
-			cltv_expiry_delta: 4,
-			htlc_minimum_msat: None,
-			htlc_maximum_msat: None,
-		});
+		let expected = vec![
+			RouteHintHop {
+				src_node_id: PublicKey::from_slice(
+					&[
+						0x02u8, 0x9e, 0x03, 0xa9, 0x01, 0xb8, 0x55, 0x34, 0xff, 0x1e, 0x92, 0xc4,
+						0x3c, 0x74, 0x43, 0x1f, 0x7c, 0xe7, 0x20, 0x46, 0x06, 0x0f, 0xcf, 0x7a,
+						0x95, 0xc3, 0x7e, 0x14, 0x8f, 0x78, 0xc7, 0x72, 0x55,
+					][..],
+				)
+				.unwrap(),
+				short_channel_id: 0x0102030405060708,
+				fees: RoutingFees { base_msat: 1, proportional_millionths: 20 },
+				cltv_expiry_delta: 3,
+				htlc_minimum_msat: None,
+				htlc_maximum_msat: None,
+			},
+			RouteHintHop {
+				src_node_id: PublicKey::from_slice(
+					&[
+						0x03u8, 0x9e, 0x03, 0xa9, 0x01, 0xb8, 0x55, 0x34, 0xff, 0x1e, 0x92, 0xc4,
+						0x3c, 0x74, 0x43, 0x1f, 0x7c, 0xe7, 0x20, 0x46, 0x06, 0x0f, 0xcf, 0x7a,
+						0x95, 0xc3, 0x7e, 0x14, 0x8f, 0x78, 0xc7, 0x72, 0x55,
+					][..],
+				)
+				.unwrap(),
+				short_channel_id: 0x030405060708090a,
+				fees: RoutingFees { base_msat: 2, proportional_millionths: 30 },
+				cltv_expiry_delta: 4,
+				htlc_minimum_msat: None,
+				htlc_maximum_msat: None,
+			},
+		];
 
 		assert_eq!(PrivateRoute::from_base32(&input), Ok(PrivateRoute(RouteHint(expected))));
 
@@ -1316,7 +1317,7 @@ mod test {
 			"0001020304050607080900010203040506070809000102030405060708090102",
 		)
 		.unwrap();
-		let description = std::iter::repeat("A").take(639).collect::<String>();
+		let description = "A".repeat(639);
 		let fallback_addr = crate::Fallback::SegWitProgram {
 			version: bitcoin::WitnessVersion::V0,
 			program: vec![0; 32],

lightning-invoice/src/test_ser_de.rs

@@ -269,7 +269,7 @@ fn private_route() {
 	use crate::{PrivateRoute, PublicKey, RouteHint, RouteHintHop, RoutingFees};
 
 	let private_route = PrivateRoute(RouteHint(vec![RouteHintHop {
-		src_node_id: PublicKey::from_slice(&vec![2; 33]).unwrap(),
+		src_node_id: PublicKey::from_slice(&[2; 33]).unwrap(),
 		short_channel_id: 0x0102030405060708,
 		fees: RoutingFees { base_msat: 1, proportional_millionths: 20 },
 		cltv_expiry_delta: 3,

lightning-liquidity/src/tests/utils.rs

@@ -40,10 +40,7 @@ pub fn to_compressed_pubkey(hex: &str) -> Option<PublicKey> {
 		Some(bytes) => bytes,
 		None => return None,
 	};
-	match PublicKey::from_slice(&data) {
-		Ok(pk) => Some(pk),
-		Err(_) => None,
-	}
+	PublicKey::from_slice(&data).ok()
 }
 
 pub fn parse_pubkey(pubkey_str: &str) -> Result<PublicKey, io::Error> {

lightning-liquidity/tests/lsps0_integration_tests.rs

@@ -51,7 +51,7 @@ fn list_protocols_integration_test() {
 	let client_handler = client_node.liquidity_manager.lsps0_client_handler();
 	let client_node_id = client_node.channel_manager.get_our_node_id();
 
-	let _ = client_handler.list_protocols(&service_node_id);
+	client_handler.list_protocols(&service_node_id);
 	let list_protocols_request = get_lsps_message!(client_node, service_node_id);
 
 	service_node

lightning-persister/src/test_utils.rs

@@ -46,7 +46,7 @@ pub(crate) fn do_read_write_remove_list_persist<K: KVStore + RefUnwindSafe>(kv_s
 
 	// Ensure we have no issue operating with primary_namespace/secondary_namespace/key being
 	// KVSTORE_NAMESPACE_KEY_MAX_LEN
-	let max_chars: String = std::iter::repeat('A').take(KVSTORE_NAMESPACE_KEY_MAX_LEN).collect();
+	let max_chars = "A".repeat(KVSTORE_NAMESPACE_KEY_MAX_LEN);
 	kv_store.write(&max_chars, &max_chars, &max_chars, &data).unwrap();
 
 	let listed_keys = kv_store.list(&max_chars, &max_chars).unwrap();