fix: account for update_monitor side effect

Author: joostjager

lightning/src/chain/channelmonitor.rs

@@ -4474,16 +4474,18 @@ impl<Signer: EcdsaChannelSigner> ChannelMonitorImpl<Signer> {
 			}
 		}
 
+		// Assume that if the updates contains no encoded channel, that the channel remained unchanged. We
+		// therefore do not update the monitor.
+		if let Some(encoded_channel) = updates.encoded_channel.as_ref() {
+			self.update_encoded_channel(encoded_channel.clone());
+		}
+
 		if ret.is_ok() {
 			if self.no_further_updates_allowed() && is_pre_close_update {
 				log_error!(logger, "Refusing Channel Monitor Update as counterparty attempted to update commitment after funding was spent");
 				Err(())
 			} else {
-				// Assume that if the updates contains no encoded channel, that the channel remained unchanged. We
-				// therefore do not update the monitor.
-				if let Some(encoded_channel) = updates.encoded_channel.as_ref() {
-					self.update_encoded_channel(encoded_channel.clone());
-				}
+
 				Ok(())
 			}
 		} else { ret }