Fix update_id gap during force_shutdown

When a channel is force-closed, there might be blocked monitor updates
not yet applied. But `latest_monitor_update_id` has been incremented and
assigned to these updates. This results in a panic when trying to apply
the `ChannelForceClosed` update. Use the unblocked update id instead.

Resolves: #3857

Author: whfuyn

lightning/src/ln/channel.rs

@@ -3440,6 +3440,13 @@ where
 		self.latest_monitor_update_id
 	}
 
+	pub fn get_latest_unblocked_monitor_update_id(&self) -> u64 {
+		if self.blocked_monitor_updates.is_empty() {
+			return self.get_latest_monitor_update_id();
+		}
+		self.blocked_monitor_updates[0].update.update_id - 1
+	}
+
 	pub fn should_announce(&self) -> bool {
 		self.config.announce_for_forwarding
 	}
@@ -5220,7 +5227,7 @@ where
 			// monitor update to the user, even if we return one).
 			// See test_duplicate_chan_id and test_pre_lockin_no_chan_closed_update for more.
 			if !self.channel_state.is_pre_funded_state() {
-				self.latest_monitor_update_id += 1;
+				self.latest_monitor_update_id = self.get_latest_unblocked_monitor_update_id() + 1;
 				Some((self.get_counterparty_node_id(), funding_txo, self.channel_id(), ChannelMonitorUpdate {
 					update_id: self.latest_monitor_update_id,
 					updates: vec![ChannelMonitorUpdateStep::ChannelForceClosed { should_broadcast }],
@@ -8582,10 +8589,8 @@ where
 	}
 
 	/// Gets the latest [`ChannelMonitorUpdate`] ID which has been released and is in-flight.
-	#[rustfmt::skip]
 	pub fn get_latest_unblocked_monitor_update_id(&self) -> u64 {
-		if self.context.blocked_monitor_updates.is_empty() { return self.context.get_latest_monitor_update_id(); }
-		self.context.blocked_monitor_updates[0].update.update_id - 1
+		self.context.get_latest_unblocked_monitor_update_id()
 	}
 
 	/// Returns the next blocked monitor update, if one exists, and a bool which indicates a