Commit 550cf91
committed
Add comment describing when a completion action can be discarded
In an older PR a reviewer had asked why the discarding of a channel
being blocked on another monitor update is okay if the blocked
channel has since closed. At the time, this was not actually okay -
the monitor updates in the channel weren't moved to the
`ChannelManager` on close so the whole pipeline was busted, but
with the changes in 4041f08 the
handling of channel closes with pending monitor updates is now
correct, and so is the existing code block.1 parent f9521a4 commit 550cf91
1 file changed
+6
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8943 | 8943 | | |
8944 | 8944 | | |
8945 | 8945 | | |
| 8946 | + | |
| 8947 | + | |
| 8948 | + | |
| 8949 | + | |
| 8950 | + | |
| 8951 | + | |
8946 | 8952 | | |
8947 | 8953 | | |
8948 | 8954 | | |
| |||
0 commit comments