Skip to content

Commit 12c52c7

Browse files
committed
Pin syn for yet another MSRV breakage
1 parent 58402ed commit 12c52c7

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -261,10 +261,10 @@ jobs:
261261
- name: Install Rust ${{ env.TOOLCHAIN }} toolchain
262262
run: |
263263
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
264-
- name: Pin the regex dependency
264+
- name: Pin the syn and regex dependencies
265265
run: |
266-
cd fuzz && cargo update -p regex --precise "1.9.6" --verbose
267-
cd write-seeds && cargo update -p regex --precise "1.9.6" --verbose
266+
cd fuzz && cargo update -p regex --precise "1.9.6" && cargo update -p syn --precise "2.0.106"
267+
cd write-seeds && cargo update -p regex --precise "1.9.6" && cargo update -p syn --precise "2.0.106"
268268
- name: Sanity check fuzz targets on Rust ${{ env.TOOLCHAIN }}
269269
run: |
270270
cd fuzz

ci/ci-tests.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ function PIN_RELEASE_DEPS {
1111
# Starting with version 1.39.0, the `tokio` crate has an MSRV of rustc 1.70.0
1212
[ "$RUSTC_MINOR_VERSION" -lt 70 ] && cargo update -p tokio --precise "1.38.1" --verbose
1313

14+
# syn 2.0.107 requires rustc 1.68.0
15+
[ "$RUSTC_MINOR_VERSION" -lt 68 ] && cargo update -p syn --precise "2.0.106" --verbose
16+
1417
return 0 # Don't fail the script if our rustc is higher than the last check
1518
}
1619

@@ -50,6 +53,7 @@ cargo test --verbose --color always
5053
echo -e "\n\nTesting upgrade from prior versions of LDK"
5154
pushd lightning-tests
5255
[ "$RUSTC_MINOR_VERSION" -lt 65 ] && cargo update -p regex --precise "1.9.6" --verbose
56+
[ "$RUSTC_MINOR_VERSION" -lt 68 ] && cargo update -p syn --precise "2.0.106" --verbose
5357
cargo test
5458
popd
5559

@@ -120,6 +124,7 @@ cargo test -p lightning-invoice --verbose --color always --no-default-features -
120124
echo -e "\n\nTesting no_std build on a downstream no-std crate"
121125
# check no-std compatibility across dependencies
122126
pushd no-std-check
127+
[ "$RUSTC_MINOR_VERSION" -lt 68 ] && cargo update -p syn --precise "2.0.106" --verbose
123128
cargo check --verbose --color always
124129
[ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
125130
popd

0 commit comments

Comments
 (0)