Drop Network newtype again

We previously (re-)introduced a newtype with the most-recent
`rust-bitcoin` update as it added the `non_exhaustive` attribute to the
`Network` enum.

However, we can now drop this newtype again as UniFFI 0.26.0 added
support for `non_exhaustive` enums.

Author: tnull

README.md

@@ -13,10 +13,11 @@ LDK Node is a self-custodial Lightning node in library form. Its central goal is
 The primary abstraction of the library is the [`Node`][api_docs_node], which can be retrieved by setting up and configuring a [`Builder`][api_docs_builder] to your liking and calling one of the `build` methods. `Node` can then be controlled via commands such as `start`, `stop`, `connect_open_channel`, `send_payment`, etc.
 
 ```rust
-use ldk_node::{Builder, Network};
+use ldk_node::Builder;
 use ldk_node::lightning_invoice::Bolt11Invoice;
 use ldk_node::lightning::ln::msgs::SocketAddress;
 use ldk_node::bitcoin::secp256k1::PublicKey;
+use ldk_node::bitcoin::Network;
 use std::str::FromStr;
 
 fn main() {

bindings/ldk_node.udl

@@ -165,6 +165,7 @@ enum PaymentStatus {
 	"Failed",
 };
 
+[NonExhaustive]
 enum Network {
 	"Bitcoin",
 	"Testnet",

src/builder.rs

@@ -9,8 +9,8 @@ use crate::peer_store::PeerStore;
 use crate::sweep::OutputSweeper;
 use crate::tx_broadcaster::TransactionBroadcaster;
 use crate::types::{
-	ChainMonitor, ChannelManager, FakeMessageRouter, GossipSync, KeysManager, Network,
-	NetworkGraph, OnionMessenger, PeerManager,
+	ChainMonitor, ChannelManager, FakeMessageRouter, GossipSync, KeysManager, NetworkGraph,
+	OnionMessenger, PeerManager,
 };
 use crate::wallet::Wallet;
 use crate::LogLevel;
@@ -49,7 +49,7 @@ use bdk::template::Bip84;
 
 use bip39::Mnemonic;
 
-use bitcoin::BlockHash;
+use bitcoin::{BlockHash, Network};
 
 #[cfg(any(vss, vss_test))]
 use bitcoin::bip32::ChildNumber;

src/lib.rs

@@ -26,9 +26,10 @@
 //! [`send_payment`], etc.:
 //!
 //! ```no_run
-//! use ldk_node::{Builder, Network};
+//! use ldk_node::Builder;
 //! use ldk_node::lightning_invoice::Bolt11Invoice;
 //! use ldk_node::lightning::ln::msgs::SocketAddress;
+//! use ldk_node::bitcoin::Network;
 //! use ldk_node::bitcoin::secp256k1::PublicKey;
 //! use std::str::FromStr;
 //!
@@ -122,7 +123,7 @@ use types::{
 	Broadcaster, ChainMonitor, ChannelManager, FeeEstimator, KeysManager, NetworkGraph,
 	PeerManager, Router, Scorer, Sweeper, Wallet,
 };
-pub use types::{ChannelDetails, Network, PeerDetails, UserChannelId};
+pub use types::{ChannelDetails, PeerDetails, UserChannelId};
 
 use logger::{log_error, log_info, log_trace, FilesystemLogger, Logger};
 
@@ -148,7 +149,7 @@ use bitcoin::hashes::sha256::Hash as Sha256;
 use bitcoin::hashes::Hash;
 use bitcoin::secp256k1::PublicKey;
 
-use bitcoin::{Address, Txid};
+use bitcoin::{Address, Network, Txid};
 
 use rand::Rng;
 
@@ -1494,7 +1495,7 @@ impl<K: KVStore + Sync + Send + 'static> Node<K> {
 	fn receive_payment_inner(
 		&self, amount_msat: Option<u64>, description: &str, expiry_secs: u32,
 	) -> Result<Bolt11Invoice, Error> {
-		let currency = Currency::from(bitcoin::Network::from(self.config.network));
+		let currency = Currency::from(self.config.network);
 		let keys_manager = Arc::clone(&self.keys_manager);
 		let invoice = match lightning_invoice::utils::create_invoice_from_channelmanager(
 			&self.channel_manager,
@@ -1547,7 +1548,8 @@ impl<K: KVStore + Sync + Send + 'static> Node<K> {
 	///
 	/// For example, you could retrieve all stored outbound payments as follows:
 	/// ```
-	/// # use ldk_node::{Builder, Config, Network, PaymentDirection};
+	/// # use ldk_node::{Builder, Config, PaymentDirection};
+	/// # use ldk_node::bitcoin::Network;
 	/// # let mut config = Config::default();
 	/// # config.network = Network::Regtest;
 	/// # config.storage_dir_path = "/tmp/ldk_node_test/".to_string();

src/types.rs

@@ -21,8 +21,6 @@ use lightning_transaction_sync::EsploraSyncClient;
 use bitcoin::secp256k1::{self, PublicKey, Secp256k1};
 use bitcoin::OutPoint;
 
-use std::fmt;
-use std::str::FromStr;
 use std::sync::{Arc, Mutex, RwLock};
 
 pub(crate) type ChainMonitor<K> = chainmonitor::ChainMonitor<
@@ -139,58 +137,6 @@ pub(crate) type Sweeper<K> = OutputSweeper<
 	Arc<FilesystemLogger>,
 >;
 
-/// The cryptocurrency network to act on.
-#[derive(Copy, PartialEq, Eq, PartialOrd, Ord, Clone, Hash, Debug)]
-pub enum Network {
-	/// Mainnet Bitcoin.
-	Bitcoin,
-	/// Bitcoin's testnet network.
-	Testnet,
-	/// Bitcoin's signet network.
-	Signet,
-	/// Bitcoin's regtest network.
-	Regtest,
-}
-
-impl TryFrom<bitcoin::Network> for Network {
-	type Error = ();
-
-	fn try_from(network: bitcoin::Network) -> Result<Self, Self::Error> {
-		match network {
-			bitcoin::Network::Bitcoin => Ok(Self::Bitcoin),
-			bitcoin::Network::Testnet => Ok(Self::Testnet),
-			bitcoin::Network::Signet => Ok(Self::Signet),
-			bitcoin::Network::Regtest => Ok(Self::Regtest),
-			_ => Err(()),
-		}
-	}
-}
-
-impl From<Network> for bitcoin::Network {
-	fn from(network: Network) -> Self {
-		match network {
-			Network::Bitcoin => bitcoin::Network::Bitcoin,
-			Network::Testnet => bitcoin::Network::Testnet,
-			Network::Signet => bitcoin::Network::Signet,
-			Network::Regtest => bitcoin::Network::Regtest,
-		}
-	}
-}
-
-impl fmt::Display for Network {
-	fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-		bitcoin::Network::from(*self).fmt(f)
-	}
-}
-
-impl FromStr for Network {
-	type Err = ();
-
-	fn from_str(s: &str) -> Result<Self, Self::Err> {
-		bitcoin::Network::from_str(s).map_err(|_| ())?.try_into()
-	}
-}
-
 /// A local, potentially user-provided, identifier of a channel.
 ///
 /// By default, this will be randomly generated for the user to ensure local uniqueness.

tests/common.rs

@@ -3,15 +3,15 @@
 
 use ldk_node::io::sqlite_store::SqliteStore;
 use ldk_node::{
-	Builder, Config, Event, LogLevel, Network, Node, NodeError, PaymentDirection, PaymentStatus,
+	Builder, Config, Event, LogLevel, Node, NodeError, PaymentDirection, PaymentStatus,
 };
 
 use lightning::ln::msgs::SocketAddress;
 use lightning::util::persist::KVStore;
 use lightning::util::test_utils::TestStore;
 use lightning_persister::fs_store::FilesystemStore;
 
-use bitcoin::{Address, Amount, OutPoint, Txid};
+use bitcoin::{Address, Amount, Network, OutPoint, Txid};
 
 use bitcoincore_rpc::bitcoincore_rpc_json::AddressType;
 use bitcoincore_rpc::Client as BitcoindClient;

tests/integration_tests_rust.rs

@@ -6,9 +6,9 @@ use common::{
 	setup_node, setup_two_nodes, wait_for_tx, TestSyncStore,
 };
 
-use ldk_node::{Builder, Event, Network, NodeError};
+use ldk_node::{Builder, Event, NodeError};
 
-use bitcoin::Amount;
+use bitcoin::{Amount, Network};
 
 use std::sync::Arc;