f Add debug assertions for payment hash overriding

Author: tnull

src/payment/store.rs

@@ -344,8 +344,16 @@ where
 		if let Some(payment) = locked_payments.get_mut(&update.id) {
 			if let Some(hash_opt) = update.hash {
 				match payment.kind {
-					PaymentKind::Bolt12Offer { ref mut hash, .. } => *hash = hash_opt,
-					PaymentKind::Bolt12Refund { ref mut hash, .. } => *hash = hash_opt,
+					PaymentKind::Bolt12Offer { ref mut hash, .. } => {
+						debug_assert_eq!(payment.direction, PaymentDirection::Outbound,
+							"We should only ever override payment hash for outbound BOLT 12 payments");
+						*hash = hash_opt
+					},
+					PaymentKind::Bolt12Refund { ref mut hash, .. } => {
+						debug_assert_eq!(payment.direction, PaymentDirection::Outbound,
+							"We should only ever override payment hash for outbound BOLT 12 payments");
+						*hash = hash_opt
+					},
 					_ => {},
 				}
 			}
@@ -381,7 +389,6 @@ where
 			self.persist_info(&update.id, payment)?;
 			updated = true;
 		}
-
 		Ok(updated)
 	}