Merge pull request #702 from izaera/lint-senna

style(senna): fix linting errors

Author: izaera

maintenance/projects/senna/examples/.eslintrc.js

@@ -0,0 +1,13 @@
+/**
+ * SPDX-FileCopyrightText: © 2021 Liferay, Inc. <https://liferay.com>
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+module.exports = {
+	globals: {
+		senna: true,
+	},
+	rules: {
+		'no-console': 'off',
+	},
+};

maintenance/projects/senna/examples/form/server.js

@@ -14,14 +14,14 @@ var upload = multer();
 
 app.use(express.static('../../'));
 
-app.post('/post', upload.array(), (req, res, next) => {
+app.post('/post', upload.array(), (req, res, _next) => {
 	var content = '<div id="result1">';
 	content += JSON.stringify(req.body, 5);
 	content += '</div>';
 	res.end(content);
 });
 
-app.post('/post-get', upload.array(), (req, res, next) => {
+app.post('/post-get', upload.array(), (_req, res, _next) => {
 	res.redirect('/examples/form/redirect.html');
 });
 

maintenance/projects/senna/examples/ga/tracker.js

@@ -3,6 +3,8 @@
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
+/* global ga */
+
 // https://developers.google.com/analytics/devguides/collection/analyticsjs/single-page-applications
 
 document.addEventListener('DOMContentLoaded', () => {

maintenance/projects/senna/examples/gallery/js/dynamic.js

@@ -56,6 +56,8 @@ document.addEventListener('DOMContentLoaded', () => {
 						return getContent('06', '07', '08');
 					case '/examples/gallery/img/08.jpg':
 						return getContent('07', '08', '01');
+					default:
+						return undefined;
 				}
 			}
 		};

maintenance/projects/senna/src/app/App.js

@@ -3,6 +3,8 @@
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
+/* eslint-disable no-console */
+
 'use strict';
 
 import {array, async, isDefAndNotNull, isString, object} from 'metal';
@@ -1272,7 +1274,11 @@ class App extends EventEmitter {
 
 		return nextScreen
 			.load(path)
-			.then(() => (this.screens[path] = nextScreen))
+			.then(() => {
+				this.screens[path] = nextScreen;
+
+				return this.screens[path];
+			})
 			.catch((reason) => {
 				this.handleNavigateError_(path, nextScreen, reason);
 				throw reason;

maintenance/projects/senna/src/app/AppDataAttributeHandler.js

@@ -3,6 +3,8 @@
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
+/* eslint-disable no-console */
+
 'use strict';
 
 import {Disposable, getUid, isDefAndNotNull, isElement, object} from 'metal';

maintenance/projects/senna/src/screen/HtmlScreen.js

@@ -117,7 +117,7 @@ class HtmlScreen extends RequestScreen {
 	 */
 	copyNodeAttributesFromContent_(content, node) {
 		content = content.replace(/[<]\s*html/gi, '<senna');
-		content = content.replace(/\/html\s*\>/gi, '/senna>');
+		content = content.replace(/\/html\s*>/gi, '/senna>');
 		let placeholder;
 		if (UA.isIe) {
 			const tempNode = globals.document

maintenance/projects/senna/src/screen/RequestScreen.js

@@ -274,6 +274,8 @@ class RequestScreen extends Screen {
 						reason.requestError = true;
 						reason.requestPrematureTermination = true;
 						break;
+					default:
+						break;
 				}
 				throw reason;
 			});

maintenance/projects/senna/src/screen/Screen.js

@@ -3,6 +3,8 @@
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
+/* eslint-disable no-console */
+
 'use strict';
 
 import {getUid} from 'metal';

maintenance/projects/senna/test/.eslintrc.js

@@ -3,8 +3,6 @@
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
-const path = require('path');
-
 module.exports = {
 	env: {
 		mocha: true,
@@ -13,4 +11,7 @@ module.exports = {
 		assert: true,
 		sinon: true,
 	},
+	rules: {
+		'no-console': 'off',
+	},
 };