Skip to content

Commit ea46ed6

Browse files
Merge pull request #699 from bryceosterhaus/311
2 parents eb2c436 + 0a81fef commit ea46ed6

File tree

66 files changed

+420
-175
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+420
-175
lines changed

.prettierrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
module.exports = {
77
bracketSpacing: false,
8+
quoteProps: 'consistent',
89
singleQuote: true,
910
tabWidth: 4,
1011
trailingComma: 'es5',

guidelines/support/checkLinks.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ const FILTER_PATTERN = /\.md$/;
2424
* See: https://github.com/liferay/liferay-frontend-guidelines/issues/133
2525
*/
2626
const HEADERS = {
27-
Accept:
27+
'Accept':
2828
'text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8',
2929
'Accept-Encoding': 'gzip, deflate, br',
3030
'Accept-Language': 'en-US,en;q=0.8,es-ES;q=0.5,es;q=0.3',
31-
DNT: '1',
31+
'DNT': '1',
3232
'User-Agent':
3333
'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:74.0) Gecko/20100101 Firefox/74.0',
3434
};

maintenance/projects/js-themes-toolkit-v8-x/.eslintrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,6 @@ module.exports = {
1414
templateFile: path.join(__dirname, 'copyright.js'),
1515
},
1616
],
17+
'promise/catch-or-return': 'off',
1718
},
1819
};

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/lib/doctor.js

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,27 +9,23 @@ const _ = require('lodash');
99

1010
const lfrThemeConfig = require('./liferay_theme_config');
1111

12-
/* eslint-disable quote-props */
13-
1412
const SUPPORTED_TASKS = {
1513
default: {
16-
6.2: ' - please run "gulp upgrade" first',
14+
'6.2': ' - please run "gulp upgrade" first',
1715
'7.0': true,
18-
7.1: true,
16+
'7.1': true,
1917
},
2018

2119
upgrade: {
22-
6.2: true,
20+
'6.2': true,
2321
'7.0': true,
24-
7.1:
22+
'7.1':
2523
' - please run ' +
2624
'"npm install --save-dev liferay-theme-tasks@9.0.0-alpha.1" ' +
2725
'and then "gulp upgrade" again',
2826
},
2927
};
3028

31-
/* eslint-enable quote-props */
32-
3329
function getSupportedTasks(task) {
3430
return SUPPORTED_TASKS[task] || SUPPORTED_TASKS.default;
3531
}

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/lib/look_and_feel_util.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const QUERY_ELEMENTS = {
1818
'layout-templates.0.custom.0.layout-template': 'id',
1919
'layout-templates.0.standard.0.layout-template': 'id',
2020
'portlet-decorator': 'id',
21-
roles: 'single',
21+
'roles': 'single',
2222
'settings.0.setting': 'key',
2323
};
2424

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/lib/lookup.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,10 @@ function lookup(key, version = null) {
2222
}
2323

2424
return {
25-
baseThemeDependencies: () =>
25+
'baseThemeDependencies': () =>
2626
require('./lookup/base').getBaseDependencies,
27-
devDependencies: () => require('./lookup/dependencies').devDependencies,
27+
'devDependencies': () =>
28+
require('./lookup/dependencies').devDependencies,
2829
'kickstart:afterPromptThemeSource': () =>
2930
require('./lookup/kickstart').afterPromptThemeSource,
3031
'kickstart:choices': () => require('./lookup/kickstart').choices,

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/lib/lookup/dependencies.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
function devDependencies(version) {
77
const dependencies = {
8-
gulp: '3.9.1',
8+
'gulp': '3.9.1',
99
'liferay-theme-tasks': '8.2.4',
1010
};
1111

maintenance/projects/js-themes-toolkit-v9-x/.eslintrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,6 @@ module.exports = {
1414
templateFile: path.join(__dirname, 'copyright.js'),
1515
},
1616
],
17+
'promise/catch-or-return': 'off',
1718
},
1819
};

maintenance/projects/js-themes-toolkit-v9-x/packages/liferay-theme-tasks/lib/devDependencies.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,18 @@ const gulpVersion = '3.9.1';
2323
const themeTasksVersion = `^${pkgJson.version}`;
2424

2525
// Define dependencies for each Liferay DXP version and project type
26-
/* eslint-disable quote-props */
26+
2727
module.exports = {
2828
layout: {
2929
7.2: {
3030
default: {
31-
gulp: gulpVersion,
31+
'gulp': gulpVersion,
3232
'liferay-theme-tasks': themeTasksVersion,
3333
},
3434
},
3535
7.3: {
3636
default: {
37-
gulp: gulpVersion,
37+
'gulp': gulpVersion,
3838
'liferay-theme-tasks': themeTasksVersion,
3939
},
4040
},
@@ -43,7 +43,7 @@ module.exports = {
4343
7.2: {
4444
default: {
4545
'compass-mixins': strict('0.12.10'),
46-
gulp: gulpVersion,
46+
'gulp': gulpVersion,
4747
'liferay-frontend-common-css': strict('1.0.4'),
4848
'liferay-frontend-theme-styled': strict('4.0.21'),
4949
'liferay-frontend-theme-unstyled': strict('4.0.17'),
@@ -56,7 +56,7 @@ module.exports = {
5656
7.3: {
5757
default: {
5858
'compass-mixins': strict('0.12.10'),
59-
gulp: gulpVersion,
59+
'gulp': gulpVersion,
6060
'liferay-frontend-common-css': strict('1.0.4'),
6161
'liferay-frontend-theme-styled': strict('5.0.15'),
6262
'liferay-frontend-theme-unstyled': strict('5.0.20'),
@@ -68,4 +68,3 @@ module.exports = {
6868
},
6969
},
7070
};
71-
/* eslint-enable quote-props */

maintenance/projects/js-themes-toolkit-v9-x/packages/liferay-theme-tasks/lib/look_and_feel_util.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const QUERY_ELEMENTS = {
1818
'layout-templates.0.custom.0.layout-template': 'id',
1919
'layout-templates.0.standard.0.layout-template': 'id',
2020
'portlet-decorator': 'id',
21-
roles: 'single',
21+
'roles': 'single',
2222
'settings.0.setting': 'key',
2323
};
2424

0 commit comments

Comments
 (0)