chore: update instances where value could be null or undefined

Author: bryceosterhaus

maintenance/projects/js-themes-toolkit-v8-x/packages/liferay-theme-tasks/test/util.js

@@ -321,7 +321,7 @@ function cleanTempTheme(themeName, version, component, initCwd) {
 
 	cleanDirectory(tempPath);
 
-	if (initCwd !== null) {
+	if (initCwd !== null && initCwd !== undefined) {
 		process.chdir(initCwd);
 	}
 }

maintenance/projects/js-themes-toolkit-v9-x/packages/liferay-theme-tasks/test/util.js

@@ -303,7 +303,7 @@ function cleanTempTheme(themeName, version, component, initCwd) {
 
 	cleanDirectory(tempPath);
 
-	if (initCwd !== null) {
+	if (initCwd !== null && initCwd !== undefined) {
 		process.chdir(initCwd);
 	}
 }

maintenance/projects/js-toolkit/packages/liferay-npm-build-support/src/scripts/translate.js

@@ -29,7 +29,7 @@ export default function () {
 		subscriptionKey = cfg.getTranslatorTextKey();
 	}
 
-	if (!subscriptionKey || subscriptionKey === '') {
+	if (!subscriptionKey) {
 		console.error(
 			'-------------------------------------------------------------\n' +
 				'    🛑 Microsoft Translator credentials not set 🛑\n\n' +

maintenance/projects/js-toolkit/packages/liferay-npm-build-tools-common/src/namespace.ts

@@ -11,7 +11,9 @@ import * as mod from './modules';
  * @return true if the module is namespaced
  */
 export function isNamespaced(moduleName: string): boolean {
-	return getNamespace(moduleName) !== null;
+	const nameSpace = getNamespace(moduleName);
+
+	return nameSpace !== null && nameSpace !== undefined;
 }
 
 /**
@@ -70,7 +72,7 @@ export function addNamespace(
 export function removeNamespace(moduleName: string): string {
 	const namespace = getNamespace(moduleName);
 
-	if (namespace !== null) {
+	if (namespace !== null && namespace !== undefined) {
 		if (moduleName.startsWith('@')) {
 			return moduleName.replace(`@${namespace}`, '@');
 		}

maintenance/projects/js-toolkit/packages/liferay-npm-bundler-loader-css-loader/src/index.js

@@ -156,7 +156,7 @@ function getHref(filePath, extension, pathModule, namespaceDependencies) {
 	if (extension !== undefined) {
 		const extname = path.extname(filePath);
 
-		if (extname === '') {
+		if (!extname) {
 			filePath = `${filePath}.${extension}`;
 		}
 		else {

maintenance/projects/js-toolkit/packages/liferay-npm-bundler-loader-sass-loader/src/index.js

@@ -67,7 +67,7 @@ function changeFilePathExtension(context) {
 
 	const extname = path.extname(filePath);
 
-	if (extname === '') {
+	if (!extname) {
 		filePath = `${filePath}.css`;
 	}
 	else {

maintenance/projects/js-toolkit/packages/liferay-npm-bundler-plugin-resolve-linked-dependencies/src/index.js

@@ -11,11 +11,14 @@ import semver from 'semver';
  * @return {void}
  */
 export default function ({log}, {pkgJson}) {
-	if (pkgJson.dependencies !== null) {
+	if (pkgJson.dependencies !== null && pkgJson.dependencies !== undefined) {
 		Object.keys(pkgJson.dependencies).forEach((name) => {
 			const link = pkgJson.dependencies[name];
 
-			if (semver.validRange(link) === null) {
+			if (
+				semver.validRange(link) === null ||
+				semver.validRange(link) === undefined
+			) {
 				const depPkgJsonPath = path.join(
 					'node_modules',
 					name,

maintenance/projects/js-toolkit/packages/liferay-npm-bundler/src/dependencies.js

@@ -65,7 +65,10 @@ export function addPackageDependencies(
 		.map((dependency) =>
 			resolveDependencyDir(baseDirPath, packageJson, dependency)
 		)
-		.filter((dependencyDir) => dependencyDir !== null);
+		.filter(
+			(dependencyDir) =>
+				dependencyDir !== null && dependencyDir !== undefined
+		);
 
 	dependencyDirs.forEach((dependencyDir) => {
 		addPackageDependencies(collectedDependencies, dependencyDir);

maintenance/projects/js-toolkit/packages/liferay-npm-bundler/src/index.ts

@@ -115,11 +115,14 @@ function run(): void {
 /** Report linked dependencies of a given package.json */
 function reportLinkedDependencies(pkgJson: object): void {
 	['dependencies', 'devDependencies'].forEach((scope) => {
-		if (pkgJson[scope] !== null) {
+		if (pkgJson[scope] !== null && pkgJson[scope] !== undefined) {
 			Object.keys(pkgJson[scope]).forEach((depName) => {
 				const depVersion = pkgJson[scope][depName];
 
-				if (semver.validRange(depVersion) === null) {
+				if (
+					semver.validRange(depVersion) === null ||
+					semver.validRange(depVersion) === undefined
+				) {
 					const depPkgJsonPath = path.join(
 						'node_modules',
 						depName,

maintenance/projects/js-toolkit/packages/liferay-npm-bundler/src/steps/rules.js

@@ -231,7 +231,7 @@ function assertString(object, field, what) {
  * @param {object} context
  */
 function writeLoadersResult(srcPkg, destPkg, context) {
-	if (context.content !== undefined) {
+	if (context.content !== undefined && context.content !== null) {
 		writeRuleFile(
 			destPkg,
 			srcPkg.dir.relative(project.dir.join(context.filePath)).asNative,
@@ -241,7 +241,7 @@ function writeLoadersResult(srcPkg, destPkg, context) {
 
 	Object.entries(context.extraArtifacts).forEach(
 		([extraPrjRelPath, content]) => {
-			if (content === undefined) {
+			if (content === undefined || content === null) {
 				return;
 			}