Skip to content

Commit 830ea00

Browse files
treat undef headers as the empty string
fixes the issue described at http://www.jwz.org/blog/2015/09/more-lwp-bit-rot/
1 parent dcfba6c commit 830ea00

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

Changes

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
Revision history for HTTP-Message
22

3+
- fix an undefined value warning in HTTP::Headers::as_string
4+
35
6.10 2015-07-19
46

57
- fix uses of qr/.../m in tests that do not work in 5.8.x

lib/HTTP/Headers.pm

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@ sub as_string
263263
my $vals = $self->{$key};
264264
if ( ref($vals) eq 'ARRAY' ) {
265265
for my $val (@$vals) {
266+
$val = '' if not defined $val;
266267
my $field = $standard_case{$key} || $self->{'::std_case'}{$key} || $key;
267268
$field =~ s/^://;
268269
if ( index($val, "\n") >= 0 ) {
@@ -272,6 +273,7 @@ sub as_string
272273
}
273274
}
274275
else {
276+
$vals = '' if not defined $vals;
275277
my $field = $standard_case{$key} || $self->{'::std_case'}{$key} || $key;
276278
$field =~ s/^://;
277279
if ( index($vals, "\n") >= 0 ) {

0 commit comments

Comments
 (0)