Fix test writing to files

There were situation when test write to local directory instead of /tmp
file. This is bad practice in testing.

Author: michal-josef-spacek

Changes

@@ -1,6 +1,7 @@
 Revision history for HTTP-Message
 
 {{$NEXT}}
+    - Fix test writing to files (GH#156) (Michal Josef Špaček)
 
 6.30      2021-05-10 14:55:55Z
     - Don't inherit from Exporter anymore (GH#155) (Max Maischein)

META.json

@@ -81,6 +81,7 @@
          "requires" : {
             "ExtUtils::MakeMaker" : "0",
             "File::Spec" : "0",
+            "File::Temp" : "0",
             "PerlIO::encoding" : "0",
             "Test::More" : "0.88",
             "Time::Local" : "0",

Makefile.PL

@@ -42,6 +42,7 @@ my %WriteMakefileArgs = (
   "TEST_REQUIRES" => {
     "ExtUtils::MakeMaker" => 0,
     "File::Spec" => 0,
+    "File::Temp" => 0,
     "PerlIO::encoding" => 0,
     "Test::More" => "0.88",
     "Time::Local" => 0,
@@ -65,6 +66,7 @@ my %FallbackPrereqs = (
   "Exporter" => "5.57",
   "ExtUtils::MakeMaker" => 0,
   "File::Spec" => 0,
+  "File::Temp" => 0,
   "HTTP::Date" => 6,
   "IO::Compress::Bzip2" => "2.021",
   "IO::Compress::Deflate" => 0,

cpanfile

@@ -28,6 +28,7 @@ suggests "Clone" => "0";
 on 'test' => sub {
   requires "ExtUtils::MakeMaker" => "0";
   requires "File::Spec" => "0";
+  requires "File::Temp" => "0";
   requires "PerlIO::encoding" => "0";
   requires "Test::More" => "0.88";
   requires "Time::Local" => "0";

t/common-req.t

@@ -4,6 +4,8 @@ use warnings;
 use Test::More;
 plan tests => 71;
 
+use File::Spec;
+use File::Temp qw(tempfile);
 use HTTP::Request::Common;
 
 my $r = GET 'http://www.sn.no/';
@@ -117,7 +119,8 @@ is($r->content_type, "text/plain");
 #
 # POST for File upload
 #
-my $file = "test-$$";
+my (undef, $file) = tempfile();
+my $form_file = (File::Spec->splitpath($file))[-1];
 open(FILE, ">$file") or die "Can't create $file: $!";
 print FILE "foo\nbar\nbaz\n";
 close(FILE);
@@ -151,7 +154,7 @@ like($c[6], qr/^--\n/);  # 5 parts + header & trailer
 ok($c[2] =~ /^Content-Disposition:\s*form-data;\s*name="email"/m);
 ok($c[2] =~ /^gisle\@aas.no$/m);
 
-ok($c[5] =~ /^Content-Disposition:\s*form-data;\s*name="file";\s*filename="$file"/m);
+ok($c[5] =~ /^Content-Disposition:\s*form-data;\s*name="file";\s*filename="$form_file"/m);
 ok($c[5] =~ /^Content-Type:\s*text\/plain$/m);
 ok($c[5] =~ /^foo\nbar\nbaz/m);
 
@@ -187,7 +190,7 @@ is($r->content_length, 13);
 #
 use HTTP::Request::Common qw($DYNAMIC_FILE_UPLOAD);
 
-$file = "test-$$";
+(undef, $file) = tempfile();
 open(FILE, ">$file") or die "Can't create $file: $!";
 for (1..1000) {
    print FILE "a" .. "z";