fix issue with HTTP::Request internal cache for canonical url when using URI::URL

Author: andrew-grechkin

Changes

@@ -1,6 +1,7 @@
 Revision history for HTTP-Message
 
 {{$NEXT}}
+    - fix issue with HTTP::Request internal cache for canonical url when using URI::URL (GH#146) (andrew-grechkin)
 
 6.28      2021-02-19 16:22:13Z
     - fix warnings during HTTP::Config->match #62 (GH#152) (Viťas Strádal)

lib/HTTP/Request.pm

@@ -96,9 +96,9 @@ sub uri_canonical
     my $uri = $self->{_uri};
 
     if (defined (my $canon = $self->{_uri_canonical})) {
-        # early bailout if these are the exact same string; try to use
-        # the cheapest comparison method possible
-        return $canon if $$canon eq $$uri;
+        # early bailout if these are the exact same string;
+        # rely on stringification of the URI objects
+        return $canon if $canon eq $uri;
     }
 
     # otherwise we need to refresh the memoized value

t/request.t

@@ -5,7 +5,7 @@ use strict;
 use warnings;
 
 use Test::More;
-plan tests => 35;
+plan tests => 39;
 
 use HTTP::Request;
 use Try::Tiny qw( catch try );
@@ -104,6 +104,22 @@ is( $r2->header("Accept-Encoding"), $req->header("Accept-Encoding") );
         },
         'Object without scheme method triggers an exception'
     );
+
+    # test uri_canonical cache
+    {
+        my $url = 'https://localhost/';
+        my $r   = HTTP::Request->new(GET => $url);
+        is($r->uri_canonical, $url, 'Works when canonical uri not yet cached');
+        is($r->uri_canonical, $url, 'Works when canonical uri has been cached');
+    }
+
+    {
+        require URI::URL;
+        my $url = 'https://localhost/';
+        my $r   = HTTP::Request->new(GET => URI::URL->new($url));
+        is($r->uri_canonical, $url, 'Works when canonical uri not yet cached with URI::URL');
+        is($r->uri_canonical, $url, 'Works when canonical uri has been cached with URI::URL');
+    }
 }
 
 eval { $req->uri ({ foo => 'bar'}); };