clean up repetitive backcompat code

Author: Grinnz

Changes

@@ -1,6 +1,7 @@
 Revision history for HTTP-Message
 
 {{$NEXT}}
+    - Clean up backcompat code (GH#148) (Dan Book)
 
 6.26      2020-09-10 02:34:25Z
     - Update comment which explains in which RFC 451 is defined (GH#143) (Olaf

lib/HTTP/Status.pm

@@ -117,35 +117,21 @@ die if $@;
 *RC_MOVED_TEMPORARILY = \&RC_FOUND;  # 302 was renamed in the standard
 push(@EXPORT, "RC_MOVED_TEMPORARILY");
 
-*RC_REQUEST_ENTITY_TOO_LARGE = \&RC_PAYLOAD_TOO_LARGE;
-push(@EXPORT, "RC_REQUEST_ENTITY_TOO_LARGE");
-
-*RC_REQUEST_URI_TOO_LARGE = \&RC_URI_TOO_LONG;
-push(@EXPORT, "RC_REQUEST_URI_TOO_LARGE");
-
-*RC_REQUEST_RANGE_NOT_SATISFIABLE = \&RC_RANGE_NOT_SATISFIABLE;
-push(@EXPORT, "RC_REQUEST_RANGE_NOT_SATISFIABLE");
-
-*RC_NO_CODE = \&RC_TOO_EARLY;
-push(@EXPORT, "RC_NO_CODE");
-
-*RC_UNORDERED_COLLECTION = \&RC_TOO_EARLY;
-push(@EXPORT, "RC_UNORDERED_COLLECTION");
-
-*HTTP_REQUEST_ENTITY_TOO_LARGE = \&HTTP_PAYLOAD_TOO_LARGE;
-push(@EXPORT_OK, "HTTP_REQUEST_ENTITY_TOO_LARGE");
-
-*HTTP_REQUEST_URI_TOO_LARGE = \&HTTP_URI_TOO_LONG;
-push(@EXPORT_OK, "HTTP_REQUEST_URI_TOO_LARGE");
-
-*HTTP_REQUEST_RANGE_NOT_SATISFIABLE = \&HTTP_RANGE_NOT_SATISFIABLE;
-push(@EXPORT_OK, "HTTP_REQUEST_RANGE_NOT_SATISFIABLE");
-
-*HTTP_NO_CODE = \&HTTP_TOO_EARLY;
-push(@EXPORT_OK, "HTTP_NO_CODE");
+my %compat = (
+    REQUEST_ENTITY_TOO_LARGE      => \&HTTP_PAYLOAD_TOO_LARGE,
+    REQUEST_URI_TOO_LARGE         => \&HTTP_URI_TOO_LONG,
+    REQUEST_RANGE_NOT_SATISFIABLE => \&HTTP_RANGE_NOT_SATISFIABLE,
+    NO_CODE                       => \&HTTP_TOO_EARLY,
+    UNORDERED_COLLECTION          => \&HTTP_TOO_EARLY,
+);
 
-*HTTP_UNORDERED_COLLECTION = \&HTTP_TOO_EARLY;
-push(@EXPORT_OK, "HTTP_UNORDERED_COLLECTION");
+foreach my $name (keys %compat) {
+    push(@EXPORT, "RC_$name");
+    push(@EXPORT_OK, "HTTP_$name");
+    no strict 'refs';
+    *{"RC_$name"} = $compat{$name};
+    *{"HTTP_$name"} = $compat{$name};
+}
 
 our %EXPORT_TAGS = (
    constants => [grep /^HTTP_/, @EXPORT_OK],