Statically allocate where possible

MasterDuke17 · MasterDuke17 · commit 12af2b36695d · 2019-08-23T18:04:52.000-04:00
diff --git a/bn_mp_todecimal_fast.c b/bn_mp_todecimal_fast.c
@@ -73,7 +73,7 @@ mp_err mp_todecimal_fast_rec(mp_int *number, mp_int *nL, mp_int *shiftL, mp_int
 mp_err mp_todecimal_fast(mp_int *number, char **result)
 {
    mp_int n, shift, M, M2, M22, M4, M44;
-   mp_int *nL, *shiftL, *mL;
+   mp_int nL[20], shiftL[20], mL[20];
    mp_err err;
    int precalc_array_index = 1;
 
@@ -91,7 +91,6 @@ mp_err mp_todecimal_fast(mp_int *number, char **result)
       goto LBL_ERR;
    }
 
-   nL = malloc(20 * sizeof(mp_int));
    if ((err = mp_init_copy(&nL[0], &n)) != MP_OKAY) {
       goto LBL_ERR;
    }
@@ -100,7 +99,6 @@ mp_err mp_todecimal_fast(mp_int *number, char **result)
       goto LBL_ERR;
    }
 
-   shiftL = malloc(20 * sizeof(mp_int));
    if ((err = mp_init_copy(&shiftL[0], &shift)) != MP_OKAY) {
       goto LBL_ERR;
    }
@@ -111,7 +109,6 @@ mp_err mp_todecimal_fast(mp_int *number, char **result)
    }
 
    /* $M / 8, rounded up */
-   mL = malloc(20 * sizeof(mp_int));
    if ((err = mp_init_set(&mL[0], (mp_digit)1049)) != MP_OKAY) {
       goto LBL_ERR;
    }

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ mp_err mp_todecimal_fast_rec(mp_int number, mp_int nL, mp_int *shiftL, mp_int`
`73`	`73`	`mp_err mp_todecimal_fast(mp_int number, char *result)`
`74`	`74`	`{`
`75`	`75`	`mp_int n, shift, M, M2, M22, M4, M44;`
`76`		`- mp_int nL, shiftL, *mL;`
	`76`	`+ mp_int nL[20], shiftL[20], mL[20];`
`77`	`77`	`mp_err err;`
`78`	`78`	`int precalc_array_index = 1;`
`79`	`79`
`@@ -91,7 +91,6 @@ mp_err mp_todecimal_fast(mp_int number, char *result)`
`91`	`91`	`goto LBL_ERR;`
`92`	`92`	`}`
`93`	`93`
`94`		`- nL = malloc(20 * sizeof(mp_int));`
`95`	`94`	`if ((err = mp_init_copy(&nL[0], &n)) != MP_OKAY) {`
`96`	`95`	`goto LBL_ERR;`
`97`	`96`	`}`
`@@ -100,7 +99,6 @@ mp_err mp_todecimal_fast(mp_int number, char *result)`
`100`	`99`	`goto LBL_ERR;`
`101`	`100`	`}`
`102`	`101`
`103`		`- shiftL = malloc(20 * sizeof(mp_int));`
`104`	`102`	`if ((err = mp_init_copy(&shiftL[0], &shift)) != MP_OKAY) {`
`105`	`103`	`goto LBL_ERR;`
`106`	`104`	`}`
`@@ -111,7 +109,6 @@ mp_err mp_todecimal_fast(mp_int number, char *result)`
`111`	`109`	`}`
`112`	`110`
`113`	`111`	`/* $M / 8, rounded up */`
`114`		`- mL = malloc(20 * sizeof(mp_int));`
`115`	`112`	`if ((err = mp_init_set(&mL[0], (mp_digit)1049)) != MP_OKAY) {`
`116`	`113`	`goto LBL_ERR;`
`117`	`114`	`}`