Fixes #507

werew · werew · commit 25c26a3b7a9a · 2019-10-03T19:57:10.000+02:00
diff --git a/src/pk/asn1/der/utf8/der_decode_utf8_string.c b/src/pk/asn1/der/utf8/der_decode_utf8_string.c
@@ -65,7 +65,7 @@ int der_decode_utf8_string(const unsigned char *in,  unsigned long inlen,
       /* count number of bytes */
       for (z = 0; (tmp & 0x80) && (z <= 4); z++, tmp = (tmp << 1) & 0xFF);
 
-      if (z > 4 || (x + (z - 1) > inlen)) {
+      if (z == 1 || z > 4 || (x + (z - 1) > inlen)) {
          return CRYPT_INVALID_PACKET;
       }
 

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ int der_decode_utf8_string(const unsigned char *in, unsigned long inlen,`
`65`	`65`	`/* count number of bytes */`
`66`	`66`	`for (z = 0; (tmp & 0x80) && (z <= 4); z++, tmp = (tmp << 1) & 0xFF);`
`67`	`67`
`68`		`- if (z > 4 \|\| (x + (z - 1) > inlen)) {`
	`68`	`+ if (z == 1 \|\| z > 4 \|\| (x + (z - 1) > inlen)) {`
`69`	`69`	`return CRYPT_INVALID_PACKET;`
`70`	`70`	`}`
`71`	`71`