Merge pull request #1092 from libgit2/ntk/warnings

Minor OCD cleanups

Author: nulltoken

LibGit2Sharp.Tests/FilterFixture.cs

@@ -238,11 +238,11 @@ public void CanFilterLargeFiles()
 
         private unsafe bool CharArrayAreEqual(char[] array1, char[] array2, int count)
         {
-            if (Object.ReferenceEquals(array1, array2))
+            if (ReferenceEquals(array1, array2))
             {
                 return true;
             }
-            if (Object.ReferenceEquals(array1, null) || Object.ReferenceEquals(null, array2))
+            if (ReferenceEquals(array1, null) || ReferenceEquals(null, array2))
             {
                 return false;
             }

LibGit2Sharp.Tests/SetErrorFixture.cs

@@ -42,7 +42,7 @@ public void FormatExceptionWithInnerException()
 
             AssertExpectedExceptionMessage(expectedMessage, exceptionToThrow);
         }
-        
+
         [Fact]
         public void FormatAggregateException()
         {

LibGit2Sharp.Tests/TestHelpers/Constants.cs

@@ -2,6 +2,7 @@
 using System.Diagnostics;
 using System.IO;
 using System.Reflection;
+using System.Security;
 using LibGit2Sharp.Core;
 
 namespace LibGit2Sharp.Tests.TestHelpers
@@ -90,11 +91,11 @@ private static string UnwrapUnixTempPath()
         }
 
         // To help with creating secure strings to test with.
-        private static System.Security.SecureString StringToSecureString(string str)
+        private static SecureString StringToSecureString(string str)
         {
             var chars = str.ToCharArray();
 
-            var secure = new System.Security.SecureString();
+            var secure = new SecureString();
             for (var i = 0; i < chars.Length; i++)
             {
                 secure.AppendChar(chars[i]);

LibGit2Sharp.Tests/TestHelpers/TestRemoteRefs.cs

@@ -1,7 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
-using System.Text;
 
 namespace LibGit2Sharp.Tests.TestHelpers
 {

LibGit2Sharp/CherryPickOptions.cs

@@ -1,7 +1,4 @@
-using LibGit2Sharp.Core;
-using LibGit2Sharp.Handlers;
-
-namespace LibGit2Sharp
+namespace LibGit2Sharp
 {
     /// <summary>
     /// Options controlling CherryPick behavior.

LibGit2Sharp/Core/GitFilter.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Runtime.InteropServices;
+
 namespace LibGit2Sharp.Core
 {
     /// <summary>
@@ -34,10 +35,10 @@ internal class GitFilter
 
         /// <summary>
         /// Initialize callback on filter
-        /// 
+        ///
         /// Specified as `filter.initialize`, this is an optional callback invoked
         /// before a filter is first used.  It will be called once at most.
-        /// 
+        ///
         /// If non-NULL, the filter's `initialize` callback will be invoked right
         /// before the first use of the filter, so you can defer expensive
         /// initialization operations (in case libgit2 is being used in a way that doesn't need the filter).
@@ -46,7 +47,7 @@ internal class GitFilter
 
         /// <summary>
         /// Shutdown callback on filter
-        /// 
+        ///
         /// Specified as `filter.shutdown`, this is an optional callback invoked
         /// when the filter is unregistered or when libgit2 is shutting down.  It
         /// will be called once at most and should release resources as needed.
@@ -57,28 +58,28 @@ internal class GitFilter
         /// <summary>
         /// Callback to decide if a given source needs this filter
         /// Specified as `filter.check`, this is an optional callback that checks if filtering is needed for a given source.
-        /// 
-        /// It should return 0 if the filter should be applied (i.e. success), GIT_PASSTHROUGH if the filter should 
+        ///
+        /// It should return 0 if the filter should be applied (i.e. success), GIT_PASSTHROUGH if the filter should
         /// not be applied, or an error code to fail out of the filter processing pipeline and return to the caller.
-        /// 
+        ///
         /// The `attr_values` will be set to the values of any attributes given in the filter definition.  See `git_filter` below for more detail.
-        /// 
-        /// The `payload` will be a pointer to a reference payload for the filter. This will start as NULL, but `check` can assign to this 
+        ///
+        /// The `payload` will be a pointer to a reference payload for the filter. This will start as NULL, but `check` can assign to this
         /// pointer for later use by the `apply` callback.  Note that the value should be heap allocated (not stack), so that it doesn't go
-        /// away before the `apply` callback can use it.  If a filter allocates and assigns a value to the `payload`, it will need a `cleanup` 
+        /// away before the `apply` callback can use it.  If a filter allocates and assigns a value to the `payload`, it will need a `cleanup`
         /// callback to free the payload.
         /// </summary>
         public delegate int git_filter_check_fn(
             GitFilter gitFilter, IntPtr payload, IntPtr filterSource, IntPtr attributeValues);
 
         /// <summary>
         /// Callback to actually perform the data filtering
-        /// 
-        /// Specified as `filter.apply`, this is the callback that actually filters data.  
+        ///
+        /// Specified as `filter.apply`, this is the callback that actually filters data.
         /// If it successfully writes the output, it should return 0.  Like `check`,
-        /// it can return GIT_PASSTHROUGH to indicate that the filter doesn't want to run. 
+        /// it can return GIT_PASSTHROUGH to indicate that the filter doesn't want to run.
         /// Other error codes will stop filter processing and return to the caller.
-        /// 
+        ///
         /// The `payload` value will refer to any payload that was set by the `check` callback.  It may be read from or written to as needed.
         /// </summary>
         public delegate int git_filter_apply_fn(
@@ -89,7 +90,7 @@ public delegate int git_filter_stream_fn(
 
         /// <summary>
         /// Callback to clean up after filtering has been applied. Specified as `filter.cleanup`, this is an optional callback invoked
-        /// after the filter has been applied.  If the `check` or `apply` callbacks allocated a `payload` 
+        /// after the filter has been applied.  If the `check` or `apply` callbacks allocated a `payload`
         /// to keep per-source filter state, use this  callback to free that payload and release resources as required.
         /// </summary>
         public delegate void git_filter_cleanup_fn(IntPtr gitFilter, IntPtr payload);

LibGit2Sharp/Core/NativeMethods.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Globalization;
 using System.IO;
-using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Runtime.ConstrainedExecution;
 using System.Runtime.InteropServices;

LibGit2Sharp/GlobalSettings.cs

@@ -171,7 +171,7 @@ internal static string GetAndLockNativeLibraryPath()
         }
 
         /// <summary>
-        /// Register a filter globally with a default priority of 200 allowing the custom filter 
+        /// Register a filter globally with a default priority of 200 allowing the custom filter
         /// to imitate a core Git filter driver. It will be run last on checkout and first on checkin.
         /// </summary>
         public static FilterRegistration RegisterFilter(Filter filter)

LibGit2Sharp/Handlers.cs

@@ -1,5 +1,4 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 
 namespace LibGit2Sharp.Handlers
 {

LibGit2Sharp/MergeAndCheckoutOptionsBase.cs

@@ -1,6 +1,5 @@
 using LibGit2Sharp.Core;
 using LibGit2Sharp.Handlers;
-using System;
 
 namespace LibGit2Sharp
 {