Always use managed https transport

Author: bording

LibGit2Sharp/Core/NativeMethods.cs

@@ -197,7 +197,7 @@ private static void InitializeNativeLibrary()
             }
 
             // Configure the .NET HTTP(S) mechanism on the first initialization of the library in the current process.
-            if (initCounter == 1 && GlobalSettings.ManagedHttpSmartSubtransportEnabled)
+            if (initCounter == 1)
             {
                 httpSubtransportRegistration = GlobalSettings.RegisterDefaultSmartSubtransport<ManagedHttpSmartSubtransport>("http");
                 httpsSubtransportRegistration = GlobalSettings.RegisterDefaultSmartSubtransport<ManagedHttpSmartSubtransport>("https");

LibGit2Sharp/GlobalSettings.cs

@@ -22,8 +22,6 @@ public static class GlobalSettings
         private static bool nativeLibraryPathLocked;
         private static string nativeLibraryDefaultPath;
 
-        private static bool useManagedHttpSmartSubtransport = true;
-
         internal class SmartSubtransportData
         {
             internal bool isCustom;
@@ -83,8 +81,6 @@ private static string GetExecutingAssemblyDirectory()
         /// </summary>
         public static Version Version => version.Value;
 
-        internal static bool ManagedHttpSmartSubtransportEnabled => RuntimeInformation.IsOSPlatform(OSPlatform.Linux) || useManagedHttpSmartSubtransport;
-
         private static SmartSubtransportData GetOrCreateSmartSubtransportData(string scheme)
         {
             Ensure.ArgumentNotNull(scheme, "scheme");
@@ -539,13 +535,5 @@ public static string GetUserAgent()
         {
             return Proxy.git_libgit2_opts_get_user_agent();
         }
-
-        /// <summary>
-        /// Enables the native http implementation. This can only be enabled on Windows or macOS.
-        /// </summary>
-        public static void UseNativeHttpTransport()
-        {
-            useManagedHttpSmartSubtransport = false;
-        }
     }
 }