Merge pull request #1221 from libgit2/ntk/xml_doc

Fix compilation warning

Author: nulltoken

LibGit2Sharp.Tests/MergeFixture.cs

@@ -361,7 +361,7 @@ public void MergeReportsCheckoutProgress()
                     OnCheckoutProgress = (path, completed, total) => wasCalled = true,
                 };
 
-                MergeResult result = repo.Merge(commitToMerge, Constants.Signature, options);
+                repo.Merge(commitToMerge, Constants.Signature, options);
 
                 Assert.True(wasCalled);
             }
@@ -384,7 +384,7 @@ public void MergeReportsCheckoutNotifications()
                     CheckoutNotifyFlags = CheckoutNotifyFlags.Updated,
                 };
 
-                MergeResult result = repo.Merge(commitToMerge, Constants.Signature, options);
+                repo.Merge(commitToMerge, Constants.Signature, options);
 
                 Assert.True(wasCalled);
                 Assert.Equal(CheckoutNotifyFlags.Updated, actualNotifyFlags);
@@ -406,7 +406,7 @@ public void FastForwardMergeReportsCheckoutProgress()
                     OnCheckoutProgress = (path, completed, total) => wasCalled = true,
                 };
 
-                MergeResult result = repo.Merge(commitToMerge, Constants.Signature, options);
+                repo.Merge(commitToMerge, Constants.Signature, options);
 
                 Assert.True(wasCalled);
             }
@@ -429,7 +429,7 @@ public void FastForwardMergeReportsCheckoutNotifications()
                     CheckoutNotifyFlags = CheckoutNotifyFlags.Updated,
                 };
 
-                MergeResult result = repo.Merge(commitToMerge, Constants.Signature, options);
+                repo.Merge(commitToMerge, Constants.Signature, options);
 
                 Assert.True(wasCalled);
                 Assert.Equal(CheckoutNotifyFlags.Updated, actualNotifyFlags);
@@ -665,7 +665,6 @@ public void MergeCanSpecifyMergeFileFavorOption(MergeFileFavor fileFavorFlag)
                 Branch branch = repo.Branches[conflictBranchName];
                 Assert.NotNull(branch);
 
-                var status = repo.RetrieveStatus();
                 MergeOptions mergeOptions = new MergeOptions()
                 {
                     MergeFileFavor = fileFavorFlag,

LibGit2Sharp.Tests/NetworkFixture.cs

@@ -189,7 +189,7 @@ public void CanPullIntoEmptyRepo()
             using (var repo = new Repository(repoPath))
             {
                 // Set up remote
-                Remote remote = repo.Network.Remotes.Add(remoteName, url);
+                repo.Network.Remotes.Add(remoteName, url);
 
                 // Set up tracking information
                 repo.Branches.Update(repo.Head,

LibGit2Sharp.Tests/PackBuilderFixture.cs

@@ -103,23 +103,13 @@ internal void AddingObjectsTestDelegate(IRepository repo, PackBuilder builder)
         [Fact]
         public void ExceptionIfPathDoesNotExist()
         {
-            PackBuilderOptions pbo;
-
-            Assert.Throws<DirectoryNotFoundException>(() =>
-            {
-                pbo = new PackBuilderOptions("aaa");
-            });
+            Assert.Throws<DirectoryNotFoundException>(() => new PackBuilderOptions("aaa"));
         }
 
         [Fact]
         public void ExceptionIfPathEqualsNull()
         {
-            PackBuilderOptions pbo;
-
-            Assert.Throws<ArgumentNullException>(() =>
-            {
-                pbo = new PackBuilderOptions(null);
-            });
+            Assert.Throws<ArgumentNullException>(() => new PackBuilderOptions(null));
         }
 
         [Fact]

LibGit2Sharp.Tests/RevertFixture.cs

@@ -67,8 +67,6 @@ public void CanRevertAndNotCommit()
             string path = SandboxRevertTestRepo();
             using (var repo = new Repository(path))
             {
-                string modifiedFileFullPath = Path.Combine(repo.Info.WorkingDirectory, revertedFile);
-
                 // Checkout the revert branch.
                 Branch branch = repo.Checkout(revertBranchName);
                 Assert.NotNull(branch);
@@ -160,6 +158,7 @@ public void RevertWithFileConflictStrategyOption(CheckoutFileConflictStrategy co
                 };
 
                 RevertResult result =  repo.Revert(repo.Head.Tip.Parents.First(), Constants.Signature, options);
+                Assert.Equal(RevertStatus.Conflicts, result.Status);
 
                 // Verify there is a conflict.
                 Assert.False(repo.Index.IsFullyMerged);
@@ -242,6 +241,7 @@ public void RevertReportsCheckoutNotification()
                 repo.Revert(repo.Head.Tip, Constants.Signature, options);
 
                 Assert.True(wasCalled);
+                Assert.Equal(CheckoutNotifyFlags.Updated, actualNotifyFlags);
             }
         }
 

LibGit2Sharp.Tests/SmartSubtransportFixture.cs

@@ -38,7 +38,7 @@ public void CustomSmartSubtransportTest(string scheme, string url)
                 registration = GlobalSettings.RegisterSmartSubtransport<MockSmartSubtransport>(scheme);
                 Assert.NotNull(registration);
 
-                using (var repo = new Repository(scd.DirectoryPath))
+                using (var repo = new Repository(repoPath))
                 {
                     Remote remote = repo.Network.Remotes.Add(remoteName, url);
 

LibGit2Sharp.Tests/StatusFixture.cs

@@ -99,7 +99,7 @@ public void RetrievingTheStatusOfADirectoryThrows()
             var path = SandboxStandardTestRepoGitDir();
             using (var repo = new Repository(path))
             {
-                Assert.Throws<AmbiguousSpecificationException>(() => { FileStatus status = repo.RetrieveStatus("1"); });
+                Assert.Throws<AmbiguousSpecificationException>(() => { repo.RetrieveStatus("1"); });
             }
         }
 

LibGit2Sharp.Tests/TestHelpers/FileExportFilter.cs

@@ -77,7 +77,6 @@ protected override void Smudge(string path, string root, Stream input, Stream ou
         {
             SmudgeCalledCount++;
 
-            string filename = Path.GetFileName(path);
             StringBuilder text = new StringBuilder();
 
             byte[] buffer = new byte[64 * 1024];

LibGit2Sharp/Filter.cs

@@ -52,7 +52,6 @@ protected Filter(string name, IEnumerable<FilterAttributeEntry> attributes)
         private readonly string name;
         private readonly IEnumerable<FilterAttributeEntry> attributes;
         private readonly GitFilter gitFilter;
-        private readonly object @lock = new object();
 
         private GitWriteStream thisStream;
         private GitWriteStream nextStream;

LibGit2Sharp/IRepository.cs

@@ -171,7 +171,7 @@ public interface IRepository : IDisposable
         /// </summary>
         /// <param name="resetMode">Flavor of reset operation to perform.</param>
         /// <param name="commit">The target commit object.</param>
-        /// <param name="opts">Collection of parameters controlling checkout behavior.</param>
+        /// <param name="options">Collection of parameters controlling checkout behavior.</param>
         void Reset(ResetMode resetMode, Commit commit, CheckoutOptions options);
 
         /// <summary>

LibGit2Sharp/RebaseOperationImpl.cs

@@ -43,24 +43,20 @@ public static RebaseResult Run(RebaseSafeHandle rebaseOperationHandle,
                 else
                 {
                     // No step to apply - need to complete the rebase.
-                    rebaseResult = CompleteRebase(rebaseOperationHandle, committer, rebaseResult);
+                    rebaseResult = CompleteRebase(rebaseOperationHandle, committer);
                 }
             }
 
             return rebaseResult;
         }
 
-        private static RebaseResult CompleteRebase(RebaseSafeHandle rebaseOperationHandle, Identity committer, RebaseResult rebaseResult)
+        private static RebaseResult CompleteRebase(RebaseSafeHandle rebaseOperationHandle, Identity committer)
         {
             long totalStepCount = Proxy.git_rebase_operation_entrycount(rebaseOperationHandle);
-            GitRebaseOptions gitRebaseOptions = new GitRebaseOptions()
-            {
-                version = 1,
-            };
 
             // Rebase is completed!
             Proxy.git_rebase_finish(rebaseOperationHandle, committer);
-            rebaseResult = new RebaseResult(RebaseStatus.Complete,
+            var rebaseResult = new RebaseResult(RebaseStatus.Complete,
                                             totalStepCount,
                                             totalStepCount,
                                             null);