Add some extra test cases

Author: nicwortel

tests/expected.log

@@ -30,28 +30,33 @@ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
 
 FILE: tests/incorrect/type-hints.php
 ------------------------------------------------------------------------------------------------------------------------
-FOUND 13 ERRORS AFFECTING 10 LINES
+FOUND 17 ERRORS AFFECTING 14 LINES
 ------------------------------------------------------------------------------------------------------------------------
   9 | ERROR | [x] Function doesNotNeedDocumentationComment() does not need documentation comment.
  16 | ERROR | [x] Function uselessReturnAnnotation() has useless @return annotation.
  23 | ERROR | [x] Function uselessParamAnnotation() has useless @param annotation for parameter $string.
- 32 | ERROR | [x] There must be no whitespace between parameter type hint nullability symbol and parameter type hint of
+ 35 | ERROR | [x] Function uselessAnnotationsWithUsefulComment() has useless @param annotation for parameter $string.
+ 37 | ERROR | [x] Function uselessAnnotationsWithUsefulComment() has useless @return annotation.
+ 46 | ERROR | [x] Function uselessAnnotationsWithUsefulAnnotation() has useless @param annotation for parameter
+    |       |     $string.
+ 48 | ERROR | [x] Function uselessAnnotationsWithUsefulAnnotation() has useless @return annotation.
+ 54 | ERROR | [x] There must be no whitespace between parameter type hint nullability symbol and parameter type hint of
     |       |     parameter $input.
- 36 | ERROR | [x] There must be exactly one space between return type hint colon and return type hint.
- 36 | ERROR | [x] There must be no whitespace between closing parenthesis and return type colon.
- 40 | ERROR | [ ] Function missingTypeHints() does not have parameter type hint nor @param annotation for its parameter
+ 58 | ERROR | [x] There must be exactly one space between return type hint colon and return type hint.
+ 58 | ERROR | [x] There must be no whitespace between closing parenthesis and return type colon.
+ 62 | ERROR | [ ] Function missingTypeHints() does not have parameter type hint nor @param annotation for its parameter
     |       |     $input.
- 40 | ERROR | [ ] Function missingTypeHints() does not have return type hint nor @return annotation for its return
+ 62 | ERROR | [ ] Function missingTypeHints() does not have return type hint nor @return annotation for its return
     |       |     value.
- 45 | ERROR | [ ] Function missingTraversableAnnotations() does not have @param annotation for its traversable
+ 67 | ERROR | [ ] Function missingTraversableAnnotations() does not have @param annotation for its traversable
     |       |     parameter $input.
- 45 | ERROR | [ ] Function missingTraversableAnnotations() does not have @return annotation for its traversable return
+ 67 | ERROR | [ ] Function missingTraversableAnnotations() does not have @return annotation for its traversable return
     |       |     value.
- 49 | ERROR | [x] Parameter $input has null default value, but is not marked as nullable.
- 54 | ERROR | [x] Expected "int" but found "integer" in @param annotation.
- 56 | ERROR | [x] Expected "bool" but found "boolean" in @return annotation.
+ 71 | ERROR | [x] Parameter $input has null default value, but is not marked as nullable.
+ 76 | ERROR | [x] Expected "int" but found "integer" in @param annotation.
+ 78 | ERROR | [x] Expected "bool" but found "boolean" in @return annotation.
 ------------------------------------------------------------------------------------------------------------------------
-PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
+PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
 ------------------------------------------------------------------------------------------------------------------------
 
 

tests/incorrect/type-hints.php

@@ -29,6 +29,28 @@ function uselessParamAnnotation(string $string, array $numbers): array
 {
 }
 
+/**
+ * This is a useful comment that should be kept
+ *
+ * @param string $string
+ *
+ * @return void
+ */
+function uselessAnnotationsWithUsefulComment(string $string): void
+{
+}
+
+/**
+ * @whatever
+ *
+ * @param string $string
+ *
+ * @return void
+ */
+function uselessAnnotationsWithUsefulAnnotation(string $string): void
+{
+}
+
 function wrongNullabilitySymbolSpacing(? string $input): string
 {
 }