Skip to content

Commit b41708e

Browse files
Merge branch 'fix/grid_map_cmake_unit_tests' into 'master'
[grid_map*] Executables are also counted for coverage, updated cmake GitOrigin-RevId: a2df6f2718b885c52de7fd267d757f108c7eb019
1 parent e3e00ff commit b41708e

File tree

12 files changed

+116
-174
lines changed

12 files changed

+116
-174
lines changed

grid_map_core/CMakeLists.txt

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ install(
106106

107107
if(CATKIN_ENABLE_TESTING)
108108
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pthread")
109-
find_package(catkin REQUIRED)
110109

111110
## Add gtest based cpp test target and link libraries
112111
catkin_add_gtest(${PROJECT_NAME}-test
@@ -126,12 +125,12 @@ if(CATKIN_ENABLE_TESTING)
126125
test/SpiralIteratorTest.cpp
127126
test/SlidingWindowIteratorTest.cpp
128127
)
129-
target_include_directories(${PROJECT_NAME}-test
130-
PRIVATE
131-
include
132-
PUBLIC SYSTEM
133-
${catkin_INCLUDE_DIRS}
134-
${EIGEN3_INCLUDE_DIR}
128+
target_include_directories(${PROJECT_NAME}-test PRIVATE
129+
include
130+
)
131+
target_include_directories(${PROJECT_NAME}-test SYSTEM PUBLIC
132+
${catkin_INCLUDE_DIRS}
133+
${EIGEN3_INCLUDE_DIR}
135134
)
136135
target_link_libraries(${PROJECT_NAME}-test
137136
${PROJECT_NAME}

grid_map_costmap_2d/CMakeLists.txt

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -64,25 +64,18 @@ install(
6464
if(CATKIN_ENABLE_TESTING)
6565
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pthread")
6666

67-
find_package(catkin REQUIRED
68-
COMPONENTS
69-
grid_map_core
70-
costmap_2d
71-
tf
72-
)
73-
7467
## Add gtest based cpp test target and link libraries
7568
catkin_add_gtest(${PROJECT_NAME}-test
7669
test/test_grid_map_costmap_2d.cpp
7770
test/Costmap2DConverterTest.cpp
7871
)
7972
add_subdirectory(rostest)
80-
target_include_directories(${PROJECT_NAME}-test
81-
PRIVATE
82-
include
83-
PUBLIC SYSTEM
84-
${catkin_INCLUDE_DIRS}
85-
${EIGEN3_INCLUDE_DIR}
73+
target_include_directories(${PROJECT_NAME}-test PRIVATE
74+
include
75+
)
76+
target_include_directories(${PROJECT_NAME}-test SYSTEM PUBLIC
77+
${catkin_INCLUDE_DIRS}
78+
${EIGEN3_INCLUDE_DIR}
8679
)
8780
target_link_libraries(${PROJECT_NAME}-test
8881
${catkin_LIBRARIES}

grid_map_cv/CMakeLists.txt

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -96,25 +96,18 @@ install(
9696
if(CATKIN_ENABLE_TESTING)
9797
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pthread")
9898

99-
find_package(catkin REQUIRED
100-
COMPONENTS
101-
grid_map_core
102-
cv_bridge
103-
filters
104-
)
105-
10699
## Add gtest based cpp test target and link libraries
107100
catkin_add_gtest(${PROJECT_NAME}-test
108101
test/test_grid_map_cv.cpp
109102
test/GridMapCvTest.cpp
110103
test/GridMapCvProcessingTest.cpp
111104
)
112-
target_include_directories(${PROJECT_NAME}-test
113-
PRIVATE
114-
include
115-
PUBLIC SYSTEM
116-
${catkin_INCLUDE_DIRS}
117-
${EIGEN3_INCLUDE_DIR}
105+
target_include_directories(${PROJECT_NAME}-test PRIVATE
106+
include
107+
)
108+
target_include_directories(${PROJECT_NAME}-test SYSTEM PUBLIC
109+
${catkin_INCLUDE_DIRS}
110+
${EIGEN3_INCLUDE_DIR}
118111
)
119112
target_link_libraries(${PROJECT_NAME}-test
120113
${PROJECT_NAME}

grid_map_demos/CMakeLists.txt

Lines changed: 35 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -60,67 +60,55 @@ include_directories(
6060
)
6161

6262
## Declare a cpp executable
63-
add_executable(
64-
simple_demo
63+
add_executable(simple_demo
6564
src/simple_demo_node.cpp
6665
)
6766

68-
add_executable(
69-
tutorial_demo
67+
add_executable(tutorial_demo
7068
src/tutorial_demo_node.cpp
7169
)
7270

73-
add_executable(
74-
iterators_demo
71+
add_executable(iterators_demo
7572
src/iterators_demo_node.cpp
7673
src/IteratorsDemo.cpp
7774
)
7875

79-
add_executable(
80-
image_to_gridmap_demo
76+
add_executable(image_to_gridmap_demo
8177
src/image_to_gridmap_demo_node.cpp
8278
src/ImageToGridmapDemo.cpp
8379
)
8480

85-
add_executable(
86-
octomap_to_gridmap_demo
81+
add_executable(octomap_to_gridmap_demo
8782
src/octomap_to_gridmap_demo_node.cpp
8883
src/OctomapToGridmapDemo.cpp
8984
)
9085

91-
add_executable(
92-
move_demo
86+
add_executable(move_demo
9387
src/move_demo_node.cpp
9488
)
9589

96-
add_executable(
97-
iterator_benchmark
90+
add_executable(iterator_benchmark
9891
src/iterator_benchmark.cpp
9992
)
10093

101-
add_executable(
102-
opencv_demo
94+
add_executable(opencv_demo
10395
src/opencv_demo_node.cpp
10496
)
10597

106-
add_executable(
107-
resolution_change_demo
98+
add_executable(resolution_change_demo
10899
src/resolution_change_demo_node.cpp
109100
)
110101

111-
add_executable(
112-
filters_demo
102+
add_executable(filters_demo
113103
src/filters_demo_node.cpp
114104
src/FiltersDemo.cpp
115105
)
116106

117-
add_executable(
118-
normal_filter_comparison_demo
107+
add_executable(normal_filter_comparison_demo
119108
src/normal_filter_comparison_node.cpp
120109
)
121110

122-
add_executable(
123-
interpolation_demo
111+
add_executable(interpolation_demo
124112
src/interpolation_demo_node.cpp
125113
src/InterpolationDemo.cpp
126114
)
@@ -227,37 +215,32 @@ install(
227215
## Test ##
228216
##############
229217
if(CATKIN_ENABLE_TESTING)
230-
find_package(catkin REQUIRED
231-
COMPONENTS
232-
roscpp
233-
grid_map_core
234-
grid_map_ros
235-
grid_map_cv
236-
grid_map_filters
237-
grid_map_loader
238-
grid_map_msgs
239-
grid_map_octomap
240-
grid_map_rviz_plugin
241-
grid_map_visualization
242-
geometry_msgs
243-
sensor_msgs
244-
cv_bridge
245-
octomap_msgs
246-
filters
247-
)
248-
249-
catkin_add_gtest(test_${PROJECT_NAME}
218+
catkin_add_gtest(${PROJECT_NAME}-test
250219
test/empty_test.cpp
251220
)
252-
target_include_directories(test_${PROJECT_NAME}
253-
PRIVATE
254-
include
255-
SYSTEM PUBLIC
256-
${catkin_INCLUDE_DIRS}
221+
add_dependencies(${PROJECT_NAME}-test
222+
filters_demo
223+
image_to_gridmap_demo
224+
interpolation_demo
225+
iterator_benchmark
226+
iterators_demo
227+
move_demo
228+
normal_filter_comparison_demo
229+
octomap_to_gridmap_demo
230+
opencv_demo
231+
resolution_change_demo
232+
simple_demo
233+
tutorial_demo
234+
)
235+
target_include_directories(${PROJECT_NAME}-test PRIVATE
236+
include
257237
)
258-
target_link_libraries(test_${PROJECT_NAME}
259-
${catkin_LIBRARIES}
238+
target_include_directories(${PROJECT_NAME}-test SYSTEM PUBLIC
239+
${catkin_INCLUDE_DIRS}
240+
)
241+
target_link_libraries(${PROJECT_NAME}-test
260242
gtest_main
243+
${catkin_LIBRARIES}
261244
)
262245

263246
###################
@@ -267,7 +250,7 @@ if(CATKIN_ENABLE_TESTING)
267250
if(cmake_code_coverage_FOUND)
268251
add_gtest_coverage(
269252
TEST_BUILD_TARGETS
270-
test_${PROJECT_NAME}
253+
${PROJECT_NAME}-test
271254
)
272255
endif()
273256
endif()

grid_map_filters/CMakeLists.txt

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -123,17 +123,15 @@ install(
123123
#############
124124

125125
if (CATKIN_ENABLE_TESTING)
126-
find_package(catkin REQUIRED)
127-
128126
catkin_add_gtest(${PROJECT_NAME}-test
129127
test/test_grid_map_filters.cpp
130128
)
131-
target_include_directories(${PROJECT_NAME}-test
132-
PRIVATE
133-
include
134-
PUBLIC SYSTEM
135-
${catkin_INCLUDE_DIRS}
136-
${TBB_INCLUDE_DIRS}
129+
target_include_directories(${PROJECT_NAME}-test PRIVATE
130+
include
131+
)
132+
target_include_directories(${PROJECT_NAME}-test SYSTEM PUBLIC
133+
${catkin_INCLUDE_DIRS}
134+
${TBB_INCLUDE_DIRS}
137135
)
138136
target_link_libraries(${PROJECT_NAME}-test
139137
${PROJECT_NAME}

grid_map_loader/CMakeLists.txt

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ include_directories(
4343
)
4444

4545
## Declare a cpp executable
46-
add_executable(
47-
${PROJECT_NAME}
46+
add_executable(${PROJECT_NAME}
4847
src/grid_map_loader_node.cpp
4948
src/GridMapLoader.cpp
5049
)
@@ -72,17 +71,18 @@ install(
7271
#############
7372

7473
if (CATKIN_ENABLE_TESTING)
75-
find_package(catkin REQUIRED)
76-
7774
catkin_add_gtest(${PROJECT_NAME}-test
7875
test/test_grid_map_loader.cpp
7976
)
80-
target_include_directories(${PROJECT_NAME}-test
81-
PRIVATE
82-
include
83-
PUBLIC SYSTEM
84-
${catkin_INCLUDE_DIRS}
85-
${EIGEN3_INCLUDE_DIRS}
77+
add_dependencies(${PROJECT_NAME}-test
78+
${PROJECT_NAME}
79+
)
80+
target_include_directories(${PROJECT_NAME}-test PRIVATE
81+
include
82+
)
83+
target_include_directories(${PROJECT_NAME}-test SYSTEM PUBLIC
84+
${catkin_INCLUDE_DIRS}
85+
${EIGEN3_INCLUDE_DIRS}
8686
)
8787

8888
###################

grid_map_octomap/CMakeLists.txt

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -93,22 +93,18 @@ install(
9393

9494
if(CATKIN_ENABLE_TESTING)
9595
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pthread")
96-
find_package(catkin REQUIRED
97-
COMPONENTS
98-
grid_map_core
99-
)
10096

10197
# Add gtest based cpp test target and link libraries
10298
catkin_add_gtest(${PROJECT_NAME}-test
10399
test/test_grid_map_octomap.cpp
104100
test/OctomapConverterTest.cpp
105101
)
106-
target_include_directories(${PROJECT_NAME}-test
107-
PRIVATE
108-
include
109-
PUBLIC SYSTEM
110-
${catkin_INCLUDE_DIRS}
111-
${OCTOMAP_INCLUDE_DIRS}
102+
target_include_directories(${PROJECT_NAME}-test PRIVATE
103+
include
104+
)
105+
target_include_directories(${PROJECT_NAME}-test SYSTEM PUBLIC
106+
${catkin_INCLUDE_DIRS}
107+
${OCTOMAP_INCLUDE_DIRS}
112108
)
113109
target_link_libraries(${PROJECT_NAME}-test
114110
${PROJECT_NAME}

grid_map_pcl/CMakeLists.txt

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,6 @@ install(
119119
if(CATKIN_ENABLE_TESTING)
120120
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pthread")
121121

122-
find_package(catkin REQUIRED
123-
COMPONENTS
124-
${CATKIN_PACKAGE_DEPENDENCIES}
125-
)
126-
127122
## Add gtest based cpp test target and link libraries
128123
catkin_add_gtest(${PROJECT_NAME}-test
129124
test/test_grid_map_pcl.cpp
@@ -133,13 +128,13 @@ if(CATKIN_ENABLE_TESTING)
133128
test/test_helpers.cpp
134129
test/PointcloudCreator.cpp
135130
)
136-
target_include_directories(${PROJECT_NAME}-test
137-
PRIVATE
138-
include
139-
PUBLIC SYSTEM
140-
${catkin_INCLUDE_DIRS}
141-
${EIGEN3_INCLUDE_DIR}
142-
${OpenMP_CXX_INCLUDE_DIRS}
131+
target_include_directories(${PROJECT_NAME}-test PRIVATE
132+
include
133+
)
134+
target_include_directories(${PROJECT_NAME}-test SYSTEM PUBLIC
135+
${catkin_INCLUDE_DIRS}
136+
${EIGEN3_INCLUDE_DIR}
137+
${OpenMP_CXX_INCLUDE_DIRS}
143138
)
144139
target_link_libraries(${PROJECT_NAME}-test
145140
${PROJECT_NAME}

0 commit comments

Comments
 (0)