✨ (roman-numerals): add third test and refactor

yuanyu90221 · yuanyu90221 · commit 28162b98eb21 · 2025-07-12T23:18:58.000+08:00
diff --git a/property-base-test/roman_number.go b/property-base-test/roman_number.go
@@ -1,8 +1,11 @@
 package roman_numerals
 
+import "strings"
+
 func ConvertToRoman(arabic int) string {
-	if arabic == 2 {
-		return "II"
+	var result strings.Builder
+	for i := arabic; i > 0; i-- {
+		result.WriteString("I")
 	}
-	return "I"
+	return result.String()
 }
diff --git a/property-base-test/roman_number_test.go b/property-base-test/roman_number_test.go
@@ -10,6 +10,7 @@ func TestRomanNumerals(t *testing.T) {
 	}{
 		{"1 gets converted to I", 1, "I"},
 		{"2 gets converted to II", 2, "II"},
+		{"3 gets converted to III", 3, "III"},
 	}
 
 	for _, test := range cases {

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,11 @@`
`1`	`1`	`package roman_numerals`
`2`	`2`
	`3`	`+import "strings"`
	`4`	`+`
`3`	`5`	`func ConvertToRoman(arabic int) string {`
`4`		`- if arabic == 2 {`
`5`		`- return "II"`
	`6`	`+ var result strings.Builder`
	`7`	`+ for i := arabic; i > 0; i-- {`
	`8`	`+ result.WriteString("I")`
`6`	`9`	`}`
`7`		`- return "I"`
	`10`	`+ return result.String()`
`8`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@ func TestRomanNumerals(t *testing.T) {`
`10`	`10`	`}{`
`11`	`11`	`{"1 gets converted to I", 1, "I"},`
`12`	`12`	`{"2 gets converted to II", 2, "II"},`
	`13`	`+ {"3 gets converted to III", 3, "III"},`
`13`	`14`	`}`
`14`	`15`
`15`	`16`	`for _, test := range cases {`